Differential D9458

[web] intorduce user profile menu to user profile modal
ClosedPublic
Actions

Authored by ginsu on Oct 12 2023, 1:33 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Jul 2, 3:09 AM

	Unknown Object (File)
	Sat, Jun 29, 8:58 AM

	Unknown Object (File)
	Tue, Jun 25, 10:16 PM

	Unknown Object (File)
	Tue, Jun 25, 10:44 AM

	Unknown Object (File)
	Mon, Jun 24, 4:45 AM

	Unknown Object (File)
	Mon, Jun 24, 2:56 AM

	Unknown Object (File)
	Mon, Jun 24, 2:56 AM

	Unknown Object (File)
	Mon, Jun 24, 2:56 AM

View All 54 Files

Subscribers

Details

Reviewers

atul
inka

Commits

rCOMM04d79b187139: [web] intorduce user profile menu to user profile modal

Summary

This diff here introduces the logic for the user profile menu into the user profile modal

Linear task: https://linear.app/comm/issue/ENG-5225/introduce-userprofilemenu

Depends on D9457

Test Plan

Confirmed that the user profile menu works as expected.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Oct 12 2023, 1:33 AM

Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptOct 12 2023, 1:33 AM

ginsu edited the summary of this revision. (Show Details)Oct 12 2023, 1:35 AM

ginsu added reviewers: atul, inka.

ginsu added a parent revision: D9457: [web] introduce UserProfileMenu.

ginsu added inline comments.

web/modals/user-profile/user-profile-modal.react.js
30–32 ↗	(On Diff #31956)	The case for anonymous users

Harbormaster completed remote builds in B23204: Diff 31956.Oct 12 2023, 1:51 AM

ginsu requested review of this revision.Oct 12 2023, 1:51 AM

atul accepted this revision.Oct 16 2023, 11:18 AM

atul added inline comments.

web/modals/user-profile/user-profile-modal.react.js
30–32 ↗	(On Diff #31956)	Was helpful to read this annotation -> it'll probably be helpful for future readers to see this as a comment
37–47 ↗	(On Diff #31956)	Let's memoize this guy

This revision is now accepted and ready to land.Oct 16 2023, 11:18 AM

address @atul's comments + rebase before landing

Harbormaster completed remote builds in B23280: Diff 32057.Oct 16 2023, 10:53 PM

Closed by commit rCOMM04d79b187139: [web] intorduce user profile menu to user profile modal (authored by ginsu). · Explain WhyOct 16 2023, 10:58 PM

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMM04d79b187139: [web] intorduce user profile menu to user profile modal.

Revision Contents
Changeset List

Path

Size

web/

modals/

user-profile/

user-profile-modal.react.js

25 lines

user-profile.react.js

7 lines

Diff 32071

web/modals/user-profile/user-profile-modal.react.js

Loading...

web/modals/user-profile/user-profile.react.js

Loading...