Differential D9798

[lib] refactor login action in `UserStore` to ops
ClosedPublic
Actions

Authored by kamil on Nov 9 2023, 6:16 AM.

Details

Reviewers

tomek

Commits

rCOMMbbcb0c1fb765: [lib] refactor login action in `UserStore` to ops

Summary

Convert logic for ops approach.

Very simple, but want to make sure ops are properly generated.

Depends on D9797

Test Plan

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Nov 9 2023, 6:16 AM

kamil held this revision as a draft.

Herald added subscribers: will, ashoat. · View Herald TranscriptNov 9 2023, 6:16 AM

kamil added a child revision: D9799: [lib] refactor update avatar action in `UserStore` to ops.Nov 9 2023, 6:17 AM

Harbormaster completed remote builds in B23957: Diff 33009.Nov 9 2023, 6:57 AM

kamil published this revision for review.Nov 10 2023, 1:53 AM

tomek accepted this revision.Nov 13 2023, 6:33 AM

This revision is now accepted and ready to land.Nov 13 2023, 6:33 AM

kamil added inline comments.Nov 14 2023, 3:44 AM

lib/reducers/user-reducer.js
220 ↗	(On Diff #33009)	Based on code in other reducers, first, we should remove all users

add removing all users

Harbormaster completed remote builds in B24170: Diff 33288.Nov 15 2023, 1:30 PM

Closed by commit rCOMMbbcb0c1fb765: [lib] refactor login action in `UserStore` to ops (authored by kamil). · Explain WhyNov 16 2023, 7:21 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMbbcb0c1fb765: [lib] refactor login action in `UserStore` to ops.

Revision Contents
Changeset List

Path

Size

lib/

reducers/

user-reducer.js

10 lines

Diff 33335

View Options

lib/reducers/user-reducer.js

[lib] refactor login action in `UserStore` to opsClosedPublicActions