Paths

Table of Contentst

Differential D9801

[lib] refactor processing updates in `UserStore` to ops
ClosedPublic
Actions

Authored by kamil on Nov 9 2023, 6:19 AM.

Tags

None

Referenced Files

	F3369015: D9801.id33289.diff
	Mon, Nov 25, 9:24 PM

	Unknown Object (File)
	Mon, Nov 25, 7:47 PM

	Unknown Object (File)
	Sun, Nov 24, 3:38 PM

	Unknown Object (File)
	Wed, Nov 20, 2:55 PM

	Unknown Object (File)
	Fri, Nov 8, 1:06 AM

	Unknown Object (File)
	Fri, Nov 8, 12:50 AM

	Unknown Object (File)
	Thu, Nov 7, 11:28 PM

	Unknown Object (File)
	Thu, Nov 7, 10:08 PM

View All 99 Files

Subscribers

Details

Reviewers

Commits

rCOMMb61ead9b2ed6: [lib] refactor processing updates in `UserStore` to ops

Summary

Convert logic for ops approach.

Depends on D9800

Test Plan

Login to two accounts that have friend relationship
On second delete account
On first make sure update is properly processed

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Nov 9 2023, 6:19 AM

kamil held this revision as a draft.

Herald added subscribers: will, ashoat. · View Herald TranscriptNov 9 2023, 6:19 AM

kamil added a child revision: D9802: [lib] refactor logout action in `UserStore` to ops.Nov 9 2023, 6:20 AM

Harbormaster completed remote builds in B23960: Diff 33012.Nov 9 2023, 7:10 AM

kamil published this revision for review.Nov 10 2023, 1:54 AM

tomek requested changes to this revision.Nov 13 2023, 6:59 AM

tomek added inline comments.

lib/reducers/user-reducer.js
265 ↗	(On Diff #33012)	There is a subtle bug here: if a user is added as a part of `convertUserInfosToReplaceUserOps` and isn't present in `state.userInfos`, we won't delete it as a part of `generateOpsForUserUpdates`. To solve this, we should modify `generateOpsForUserUpdates` so that it adds an op regardless of the provided state.

This revision now requires changes to proceed.Nov 13 2023, 6:59 AM

address review

Harbormaster completed remote builds in B24171: Diff 33289.Nov 15 2023, 1:47 PM

tomek accepted this revision.Nov 16 2023, 3:14 AM

tomek added inline comments.

lib/reducers/user-reducer.js
163 ↗	(On Diff #33289)	Do we need this parameter?

This revision is now accepted and ready to land.Nov 16 2023, 3:14 AM

remove unused param

This revision was landed with ongoing or failed builds.Nov 16 2023, 7:21 AM

Closed by commit rCOMMb61ead9b2ed6: [lib] refactor processing updates in `UserStore` to ops (authored by kamil). · Explain Why

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMb61ead9b2ed6: [lib] refactor processing updates in `UserStore` to ops.

Harbormaster completed remote builds in B24206: Diff 33331.Nov 16 2023, 7:41 AM

Revision Contents
Changeset List

Path

Size

lib/

reducers/

user-reducer.js

28 lines

shared/

updates/

delete-account-spec.js

3 lines

4 lines

Diff 33338

lib/reducers/user-reducer.js

Loading...

lib/shared/updates/delete-account-spec.js

Loading...

lib/shared/updates/update-spec.js

Loading...