Page MenuHomePhabricator
Differential D3671

[web] Adjust `MembersModal` size to match designs
ClosedPublic
Actions

Authored by • jacek on Apr 8 2022, 5:58 AM.
Tags
None
Referenced Files
F5257947: D3671.diff
Sun, Apr 6, 10:12 AM
Unknown Object (File)
Wed, Apr 2, 8:33 AM
Unknown Object (File)
Mon, Mar 31, 8:48 PM
Unknown Object (File)
Mon, Mar 31, 4:10 AM
Unknown Object (File)
Sun, Mar 30, 11:06 PM
Unknown Object (File)
Sun, Mar 30, 9:54 PM
Unknown Object (File)
Sun, Mar 30, 8:53 PM
Unknown Object (File)
Sun, Mar 30, 11:03 AM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul
• benschac
• karol
tomek

Details

Reviewers
tomek
atul
• benschac
Commits
rCOMM7daabdc391c1: [web] Adjust `MembersModal` size to match designs
Summary

Changed MembersModal content size in order to make the whole modal size exactly the same as in design.

Screenshot_Google Chrome_2022-04-11_084216.png (955×1 px, 140 KB)

Test Plan

Open Members modal from thread actions menu.

Diff Detail

Repository
rCOMM Comm
Branch
jacek/modal-7
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• jacek created this revision.Apr 8 2022, 5:58 AM
Herald added subscribers: • abosh, • benschac, • karol and 4 others. · View Herald TranscriptApr 8 2022, 5:58 AM
• jacek added a parent revision: D3670: [web] Allow passing `Modal` parameters into `SearchModal`.Apr 8 2022, 5:59 AM
• jacek added a parent revision: D3669: [web] Redesign `Modal` to match Figma.
Harbormaster completed remote builds in B8023: Diff 11228.Apr 8 2022, 6:05 AM
• jacek requested review of this revision.Apr 8 2022, 6:05 AM
• jacek added reviewers: tomek, atul, • benschac.Apr 8 2022, 6:07 AM
atul accepted this revision.Apr 8 2022, 11:20 AM

(would be good to add a screenshot just to see how it looks with these dimensions)

web/modals/threads/members/members-modal.css
2–3

(I don't think we need to match the dimensions from Figma exactly, I don't think those designs were intended to be pixel perfect... but if it looks good then it's fine)

This revision is now accepted and ready to land.Apr 8 2022, 11:20 AM
atul mentioned this in D3672: [web] Adjust `SubchannelsModal` size to match designs.Apr 8 2022, 11:22 AM
• jacek edited the summary of this revision. (Show Details)Apr 10 2022, 11:42 PM
• jacek updated this revision to Diff 11881.Apr 25 2022, 10:29 AM

rebase

Harbormaster completed remote builds in B8522: Diff 11881.Apr 25 2022, 10:46 AM
• jacek updated this revision to Diff 11926.Apr 26 2022, 8:34 AM

rebase

Harbormaster completed remote builds in B8557: Diff 11926.Apr 26 2022, 8:52 AM
Closed by commit rCOMM7daabdc391c1: [web] Adjust `MembersModal` size to match designs (authored by • jacek). · Explain WhyApr 26 2022, 9:09 AM
This revision was automatically updated to reflect the committed changes.
• jacek added a commit: rCOMM7daabdc391c1: [web] Adjust `MembersModal` size to match designs.

Revision Contents
Changeset List

PathSize
web/
components/
1 line
modals/
threads/
members/
5 lines
12 lines

Diff 11228

View Options

web/components/tabs.css

FROM commapp/services-base:1.2 FROM commapp/services-base:1.3
RUN apt-get update && \ RUN apt-get update && \
apt-get install -y uuid-dev && \ apt-get install -y uuid-dev && \
rm -rf /var/lib/apt/lists/* rm -rf /var/lib/apt/lists/*
ARG COMM_TEST_SERVICES ARG COMM_TEST_SERVICES
ARG COMM_SERVICES_SANDBOX ARG COMM_SERVICES_SANDBOX
ENV COMM_TEST_SERVICES=${COMM_TEST_SERVICES} ENV COMM_TEST_SERVICES=${COMM_TEST_SERVICES}
ENV COMM_SERVICES_SANDBOX=${COMM_SERVICES_SANDBOX} ENV COMM_SERVICES_SANDBOX=${COMM_SERVICES_SANDBOX}
WORKDIR /transferred WORKDIR /transferred
COPY native/cpp/CommonCpp/grpc/protos/blob.proto protos/blob.proto
COPY services/lib/cmake-components cmake-components
COPY services/lib/docker/ scripts/ COPY services/lib/docker/ scripts/
COPY services/blob/ . COPY services/blob/ blob
COPY services/lib/src/* src/ COPY services/lib/src lib/src/
RUN scripts/build_service.sh WORKDIR /transferred/blob
ADD native/cpp/CommonCpp/grpc grpc
RUN ../scripts/build_service.sh
WORKDIR /transferred
CMD if [ "$COMM_TEST_SERVICES" -eq 1 ]; then scripts/run_tests.sh; else scripts/run_service.sh; fi CMD if [ "$COMM_TEST_SERVICES" -eq 1 ]; then scripts/run_tests.sh; else scripts/run_service.sh; fi
View Options

web/modals/threads/members/members-modal.css

FROM commapp/services-base:1.2 FROM commapp/services-base:1.3
RUN apt-get update && \ RUN apt-get update && \
apt-get install -y uuid-dev && \ apt-get install -y uuid-dev && \
rm -rf /var/lib/apt/lists/* rm -rf /var/lib/apt/lists/*
ARG COMM_TEST_SERVICES ARG COMM_TEST_SERVICES
ARG COMM_SERVICES_SANDBOX ARG COMM_SERVICES_SANDBOX
ENV COMM_TEST_SERVICES=${COMM_TEST_SERVICES} ENV COMM_TEST_SERVICES=${COMM_TEST_SERVICES}
ENV COMM_SERVICES_SANDBOX=${COMM_SERVICES_SANDBOX} ENV COMM_SERVICES_SANDBOX=${COMM_SERVICES_SANDBOX}
WORKDIR /transferred WORKDIR /transferred
COPY native/cpp/CommonCpp/grpc/protos/blob.proto protos/blob.proto
COPY services/lib/cmake-components cmake-components
COPY services/lib/docker/ scripts/ COPY services/lib/docker/ scripts/
COPY services/blob/ . COPY services/blob/ blob
COPY services/lib/src/* src/ COPY services/lib/src lib/src/
RUN scripts/build_service.sh WORKDIR /transferred/blob
ADD native/cpp/CommonCpp/grpc grpc
RUN ../scripts/build_service.sh
WORKDIR /transferred
CMD if [ "$COMM_TEST_SERVICES" -eq 1 ]; then scripts/run_tests.sh; else scripts/run_service.sh; fi CMD if [ "$COMM_TEST_SERVICES" -eq 1 ]; then scripts/run_tests.sh; else scripts/run_service.sh; fi
View Options

web/modals/threads/members/members-modal.react.js

FROM commapp/services-base:1.2 FROM commapp/services-base:1.3
RUN apt-get update && \ RUN apt-get update && \
apt-get install -y uuid-dev && \ apt-get install -y uuid-dev && \
rm -rf /var/lib/apt/lists/* rm -rf /var/lib/apt/lists/*
ARG COMM_TEST_SERVICES ARG COMM_TEST_SERVICES
ARG COMM_SERVICES_SANDBOX ARG COMM_SERVICES_SANDBOX
ENV COMM_TEST_SERVICES=${COMM_TEST_SERVICES} ENV COMM_TEST_SERVICES=${COMM_TEST_SERVICES}
ENV COMM_SERVICES_SANDBOX=${COMM_SERVICES_SANDBOX} ENV COMM_SERVICES_SANDBOX=${COMM_SERVICES_SANDBOX}
WORKDIR /transferred WORKDIR /transferred
COPY native/cpp/CommonCpp/grpc/protos/blob.proto protos/blob.proto
COPY services/lib/cmake-components cmake-components
COPY services/lib/docker/ scripts/ COPY services/lib/docker/ scripts/
COPY services/blob/ . COPY services/blob/ blob
COPY services/lib/src/* src/ COPY services/lib/src lib/src/
RUN scripts/build_service.sh WORKDIR /transferred/blob
ADD native/cpp/CommonCpp/grpc grpc
RUN ../scripts/build_service.sh
WORKDIR /transferred
CMD if [ "$COMM_TEST_SERVICES" -eq 1 ]; then scripts/run_tests.sh; else scripts/run_service.sh; fi CMD if [ "$COMM_TEST_SERVICES" -eq 1 ]; then scripts/run_tests.sh; else scripts/run_service.sh; fi