Differential D3894

[lib] [refactor] [ENG-530] remove list of users string in reply
AcceptedPublic
Actions

Authored by • benschac on May 3 2022, 3:47 AM.

Tags

None

Referenced Files

	F3353230: D3894.diff
	Sat, Nov 23, 8:56 AM

	Unknown Object (File)
	Fri, Nov 15, 6:38 PM

	Unknown Object (File)
	Fri, Nov 15, 6:10 AM

	Unknown Object (File)
	Wed, Nov 6, 2:28 PM

	Unknown Object (File)
	Mon, Oct 28, 9:32 PM

	Unknown Object (File)
	Mon, Oct 28, 1:57 AM

	Unknown Object (File)
	Oct 20 2024, 3:56 AM

	Unknown Object (File)
	Oct 8 2024, 1:52 PM

Subscribers

Details

Reviewers

ashoat
atul

Summary

The design no longer calls for a list of users who have replied to the sidebar figma: https://www.figma.com/file/a1nkbWgbgjRlrOY9LVurTz/Comm-%2F-Desktop-app?node-id=1170%3A77791 in reply

https://linear.app/comm/issue/ENG-530/inline-sidebar-re-style

Test Plan

No test plan, other than confirming the design doesn't have the functionality I'm removing. I did speak with ashoat about the hover functionality of the reply bubble where users' names would show. He was a bit on the fence about it. Either way, we have this commit in git history and can always grab it and re-introduce if needed.

Additionally, this shouldn't be landed until the stack is ready.

Diff Detail

Repository

Branch

inline-sidebar-web-and-native-ENG-530

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• benschac created this revision.May 3 2022, 3:47 AM

Herald added subscribers: • abosh, • karol, • adrian, tomek. · View Herald TranscriptMay 3 2022, 3:47 AM

• benschac edited the test plan for this revision. (Show Details)May 3 2022, 3:48 AM

• benschac edited the summary of this revision. (Show Details)

• benschac edited the test plan for this revision. (Show Details)

• benschac added a parent revision: D3893: [web] [chore] [ENG-530] remove old styles from inline sidebar component.May 3 2022, 3:50 AM

Harbormaster completed remote builds in B8730: Diff 12161.May 3 2022, 3:52 AM

• benschac requested review of this revision.May 3 2022, 3:52 AM

• benschac added a child revision: D3895: [web] [chore] [ENG-530] style inline sidebar.May 3 2022, 4:51 AM

• benschac added a child revision: D3897: [native] [chore] [ENG-530] remove arrows from inline sidebar.May 3 2022, 7:29 AM

ashoat accepted this revision.May 3 2022, 9:31 AM

This revision is now accepted and ready to land.May 3 2022, 9:31 AM

@jacek Might be relevant to your current work?

Revision Contents
Changeset List

Path

Size

lib/

hooks/

inline-sidebar-text.react.js

18 lines

utils/

15 lines

native/

chat/

inline-sidebar.react.js

7 lines

web/

chat/

inline-sidebar.react.js

7 lines

Diff 12161

lib/hooks/inline-sidebar-text.react.js

Loading...

lib/utils/text-utils.js

Loading...

native/chat/inline-sidebar.react.js

Loading...

web/chat/inline-sidebar.react.js

Loading...