Our DatabaseClient will fetch user tokens from DynamoDB. We need a struct to store the data pertaining to a token.
We use the chrono crate to handle date/time
Differential D3945
[Identity] Add new types to handle tokens varun on May 6 2022, 7:15 AM. Authored by Tags None Referenced Files
Details Our DatabaseClient will fetch user tokens from DynamoDB. We need a struct to store the data pertaining to a token. We use the chrono crate to handle date/time cargo build
Diff Detail
Event TimelineComment Actions Why you don't put [services] prefix in your revisions' names for the identity service? I thought we had a convention that we put a prefix depending on the "module" we work on. So, for instance, [web], [server], [native]. [services] Is at the same level, [identity] is deeper one level. Is there a particular reason you do not do this here? Has this rule changed?
Comment Actions I have this pattern but I've actually never pushed it as a rule. The other day @jonringer-comm asked me if he should prefix his commit titles with [nix], so this is coming up in multiple places. Open to creating a rule for this but curious for other perspectives Comment Actions I see. For me, personally, it would be handier because I set my herald rule to detect any revisions with [services] in their names. If you decide to user other naming then fine but I think it will be better for everybody to use one, consistent pattern. As a side note, maybe we could use tags? Comment Actions i'll use [services][identity] going forward. are herald rules case sensitive?
Comment Actions Rename Token to AccessToken to be more precise, make token field optional (to handle incomplete data in DynamoDB) Comment Actions back to you
|