[native] [fix] [ENG-1123] update message chat bubble design to match design (more padding and line height)
AbandonedPublic
Actions

Authored by • benschac on May 10 2022, 11:45 AM.

Details

Reviewers

atul
• jacek
tomek
ashoat

Summary

https://linear.app/comm/issue/ENG-1123/update-chat-bubble-design-to-match-figma, the message bubble needs to be updated so that the reply-engagement component isn't too cramped next to the text in the message bubble. Additionally, these changes are in line with mainstream messaging design.

with chat bubble changes:

without chat bubble changes:

making @ashoat the blocking reviewer here because I know he'll have some feedback/comments since this change is highly visible.

Test Plan

review figma, and make sure this looks like the design.

Diff Detail

Repository

rCOMM Comm

Branch

inline-sidebar-web-and-native-ENG-530

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• benschac created this revision.May 10 2022, 11:45 AM

Herald added subscribers: • abosh, • adrian, ashoat. · View Herald TranscriptMay 10 2022, 11:45 AM

remove line

Harbormaster completed remote builds in B8993: Diff 12527.May 10 2022, 11:50 AM

• benschac edited the summary of this revision. (Show Details)May 10 2022, 11:51 AM

• benschac added a reviewer: ashoat.

• benschac added inline comments.May 10 2022, 11:54 AM

native/chat/inner-text-message.react.js
143 ↗	(On Diff #12528)	I actually think this is a bit too small. But that's what's in the design. https://www.figma.com/file/L675ETKDnGaSwlpZAw4MIC/Mobile-App?node-id=351%3A455 @ashoat - I think 16px looks better.

Harbormaster completed remote builds in B8994: Diff 12528.May 10 2022, 11:55 AM

• benschac requested review of this revision.May 10 2022, 11:55 AM

• benschac retitled this revision from [native] [fix] [ENG-1123] update message chat bubble design to [native] [fix] [ENG-1123] update message chat bubble design to match design (more padding and line height).May 10 2022, 11:55 AM

• benschac edited the summary of this revision. (Show Details)

• benschac added a parent revision: D3997: [native] [refactor] [ENG-530] refactor container margin bottom if statement.

• benschac added a child revision: D4001: [native] [feat] [ENG-530] add new styles to inline sidebar component.May 11 2022, 7:42 AM

We should not reduce text size like this. Can you sync with @atul to figure out an alternative to your concerns about the design? And then when you guys have a concrete proposal we can move forward

This revision now requires changes to proceed.May 11 2022, 5:47 PM

See here for some additional notes, basically making the chat bubbles look more like the Figma is a non-goal

ashoat mentioned this in D4001: [native] [feat] [ENG-530] add new styles to inline sidebar component.May 11 2022, 6:05 PM

In D3998#112430, @ashoat wrote:

See here for some additional notes, basically making the chat bubbles look more like the Figma is a non-goal

I chatted with @atul about this last week. I'm going to revert all changes regarding the chat bubbles. We thought possibly adding some padding to the bottom of the chat bubble where InlineEngadement is placed would help make the spacing look less cramped, but after reading your comment, that seems dangerous, with the possibility of more churn on this diff. I'm going to remove these changes from the stack. If things look cramped to you (@ashoat) then, let's address it.

• benschac abandoned this revision.May 23 2022, 11:12 AM