[web] Search for the users on server
ClosedPublic
Actions

Authored by tomek on Jun 14 2022, 12:34 PM.

Details

Reviewers

• jacek
atul
• benschac

Commits

rCOMM87dce9d6e6e0: [web] Search for the users on server

Summary

Another source of the users is our server - there might be some users that aren't in the store, but it should be possible to friend / block them.

Depends on D4267

Test Plan

Render the component and check if all the users that match search text were returned from the server.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

tomek created this revision.Jun 14 2022, 12:34 PM

Herald added subscribers: • abosh, • adrian, ashoat. · View Herald TranscriptJun 14 2022, 12:34 PM

tomek added a child revision: D4269: [web] Merge store and server search results.Jun 14 2022, 12:37 PM

Harbormaster completed remote builds in B9757: Diff 13507.Jun 14 2022, 12:39 PM

tomek requested review of this revision.Jun 14 2022, 12:39 PM

Considering this network request may take some time to complete, we should probably introduce a spinner or something here to indicate to the user that "something is happening."

Guessing that feedback will probably be more relevant later in the stack once you're working on the views though.

web/settings/relationship/add-users-list.react.js
22	If we move the `const userStoreSearchIndex = ...` line above this one, can we replace `new Set()` with: new Set(userStoreSearchIndex.getSearchResults(searchText) ?

This revision is now accepted and ready to land.Jun 17 2022, 1:24 PM

In D4268#120826, @atul wrote:

Considering this network request may take some time to complete, we should probably introduce a spinner or something here to indicate to the user that "something is happening."

Guessing that feedback will probably be more relevant later in the stack once you're working on the views though.

We can do that but need to find a good place for it. We don't want to stop users from interacting with the component because we're fetching some data. Also, there will be some users displayed (from the store), so adding a spinner is not that beneficial... what do you think?