Page MenuHomePhabricator

[web] Create AddUsersList component that fetches users from the store
ClosedPublic

Authored by tomek on Jun 14 2022, 12:31 PM.
Tags
None
Referenced Files
F3488392: D4267.diff
Wed, Dec 18, 9:51 AM
Unknown Object (File)
Sun, Dec 1, 10:16 PM
Unknown Object (File)
Sun, Dec 1, 7:15 PM
Unknown Object (File)
Sun, Dec 1, 7:15 PM
Unknown Object (File)
Sun, Dec 1, 2:45 AM
Unknown Object (File)
Nov 9 2024, 7:59 AM
Unknown Object (File)
Oct 17 2024, 4:05 PM
Unknown Object (File)
Oct 14 2024, 12:46 AM

Details

Summary

This component is responsible for displaying a list of users that can be added to friend / block list. To get a list of users we start by searching our store.

Depends on D4266

Test Plan

Render the component and check if all the users that match search text were returned.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul requested changes to this revision.Jun 16 2022, 8:03 AM

Is this component supposed to return null at this point?

Was a little confused because the state stuff looks correct, but the component isn't displaying anything yet. Even just an unstyled list of <p>'s would probably be good?

web/settings/relationship/add-users-list.react.js
27 ↗(On Diff #13506)

Is this component supposed to be returning null at this point?

Wondering because the "Test Plan" has the following:

Render the component and check if all the users that match search text were returned.


Or was it intentional for this diff to exclude the "view" and focus on the state stuff?

This revision now requires changes to proceed.Jun 16 2022, 8:03 AM

Okay never mind, looking at subsequent diffs I see how this gets built up

This revision is now accepted and ready to land.Jun 16 2022, 8:05 AM

Sorry for the confusion! I should've said that the next couple of diffs build this component step-by-step - the rendering will be added a lot later.

Use search result instead of empty set as an initial value