Create a list of users and sort it by username.
Depends on D4269
Details
Details
Render the component and check if the list is sorted correctly.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
Looks good! Added alternative approach using .map(...).sort(...) as an inline comment, but feel free to land with either approach
| web/settings/relationship/add-users-list.react.js | ||
|---|---|---|
| 73–79 ↗ | (On Diff #13619) | Not sure if this is more/less readable, but I think we could do something like this as well: return mergedUserInfos
.map(({ userID }) => mergedUserInfos[userID])
.sort((user1, user2) => user1.username.localeCompare(user2.username)); |
| web/settings/relationship/add-users-list.react.js | ||
|---|---|---|
| 73–79 ↗ | (On Diff #13619) | Good catch - using functional approach is an improvement. Your proposition needs to be modified, because mergedUserInfos is an object. We should use Object.keys(mergedUserInfos) instead. |