Details

Reviewers

• max
• karol
varun
atul
ashoat

Commits

rCOMM0cb68e57850f: Update android build with cmake changes

Summary

This is a much more minimal diff
of D4433. This does the "minimal" needed to
fix the android build, without trying to
change anything about the gradle build.

Depends on D4294

Test Plan

cd native/android && ./gradew bundleRelease --no-daemon

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• jon created this revision.Jul 5 2022, 11:58 AM

Herald added subscribers: • abosh, atul, • adrian, tomek. · View Herald TranscriptJul 5 2022, 11:58 AM

• jon edited the summary of this revision. (Show Details)Jul 5 2022, 11:59 AM

• jon added a parent revision: D4447: Update modules build after changes to master.

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 5 2022, 12:05 PM

Harbormaster failed remote builds in B10302: Diff 14202!

• jon added a child revision: D4452: Update xcode project with new header search paths.Jul 5 2022, 12:18 PM

• jon edited the summary of this revision. (Show Details)Jul 6 2022, 10:26 AM

Update header paths with changes from master

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 6 2022, 1:39 PM

Harbormaster failed remote builds in B10328: Diff 14236!

Update with changes to master

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 7 2022, 3:11 PM

Harbormaster failed remote builds in B10385: Diff 14295!

Fix bad merge conflict, accidently dropped a header

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 7 2022, 4:14 PM

Harbormaster failed remote builds in B10395: Diff 14305!

• jon requested review of this revision.Jul 7 2022, 6:36 PM

• jon added reviewers: varun, atul.

Resigning since I'm usually not a good person to set as a first-pass reviewer. Exceptions here

Maybe set @palys-swm or @atul as a blocking reviewer here

cd native/android/app && ./gradew bundleRelease --no-daemon

Think this is supposed to be:

cd native/android && ./gradlew bundleRelease --no-daemon

atul accepted this revision.Jul 15 2022, 12:00 PM

This revision is now accepted and ready to land.Jul 15 2022, 12:00 PM

Rebase

Harbormaster failed remote builds in B10615: Diff 14608!Jul 18 2022, 5:45 PM

• jon edited the test plan for this revision. (Show Details)Jul 18 2022, 5:59 PM

Update internal path

Harbormaster failed remote builds in B10617: Diff 14610!Jul 18 2022, 6:12 PM

Restore old include paths

Harbormaster failed remote builds in B10619: Diff 14612!Jul 18 2022, 6:42 PM

Fix another path

• jon edited the summary of this revision. (Show Details)Jul 18 2022, 7:01 PM

• jon added a parent revision: D4294: [nix] Add dependencies needed to compile native modules.

• jon removed a parent revision: D4447: Update modules build after changes to master.

Harbormaster failed remote builds in B10621: Diff 14614!Jul 18 2022, 7:09 PM

Fix another path...

Harbormaster failed remote builds in B10622: Diff 14615!Jul 18 2022, 7:23 PM

Add missing header

Harbormaster completed remote builds in B10623: Diff 14616.Jul 18 2022, 9:37 PM

@atul yes, it was supposed to be native/android, native/android/app has the CMakeLists.txt, but should have mentioned the directory which contained the gradlew

Update with linting changes

Harbormaster completed remote builds in B10695: Diff 14727.Jul 20 2022, 12:52 PM

@atul I'm assuming this is still fine?

In D4448#131128, @jon wrote:

@atul I'm assuming this is still fine?

Yup!

This revision is now accepted and ready to land.Jul 20 2022, 3:03 PM

Closed by commit rCOMM0cb68e57850f: Update android build with cmake changes (authored by • jon). · Explain WhyJul 20 2022, 3:18 PM

This revision was automatically updated to reflect the committed changes.

• jon added a commit: rCOMM0cb68e57850f: Update android build with cmake changes.

• jon mentioned this in D4483: [Nix] Support building Android through gradle on Linux.Jul 20 2022, 5:27 PM

Update android build with cmake changes
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 14727

native/android/app/CMakeLists.txt

native/android/app/src/cpp/CommSecureStore.cpp

native/android/app/src/cpp/GlobalNetworkSingletonJNIHelper.cpp

native/android/app/src/cpp/Logger.cpp

native/android/app/src/cpp/MessageOperationsUtilitiesJNIHelper.cpp

native/android/app/src/cpp/PlatformSpecificTools.cpp

native/android/app/src/cpp/ThreadOperationsJNIHelper.cpp

native/android/app/src/cpp/jsiInstaller.cpp

Update android build with cmake changesClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 14727

native/android/app/CMakeLists.txt

native/android/app/src/cpp/CommSecureStore.cpp

native/android/app/src/cpp/GlobalNetworkSingletonJNIHelper.cpp

native/android/app/src/cpp/Logger.cpp

native/android/app/src/cpp/MessageOperationsUtilitiesJNIHelper.cpp

native/android/app/src/cpp/PlatformSpecificTools.cpp

native/android/app/src/cpp/ThreadOperationsJNIHelper.cpp

native/android/app/src/cpp/jsiInstaller.cpp

Update android build with cmake changes
ClosedPublic
Actions

Revision Contents
Changeset List