Page MenuHomePhabricator
Differential D4734

[Services] Allow for docker paths and system packages
ClosedPublic
Actions

Authored by • jon on Aug 3 2022, 11:22 PM.
Tags
None
Referenced Files
F3273745: D4734.id15293.diff
Sat, Nov 16, 6:16 AM
Unknown Object (File)
Sun, Oct 27, 6:36 AM
Unknown Object (File)
Sun, Oct 27, 6:36 AM
Unknown Object (File)
Sun, Oct 27, 6:36 AM
Unknown Object (File)
Sun, Oct 27, 6:35 AM
Unknown Object (File)
Sun, Oct 27, 6:30 AM
Unknown Object (File)
Sep 28 2024, 9:24 AM
Unknown Object (File)
Sep 27 2024, 4:03 AM
View All Files
Subscribers
• adrian
ashoat
tomek

Details

Reviewers
atul
• abosh
• max
• karol
Commits
rCOMM1ce887c5239d: [Services] Allow for docker paths and system packages
Summary

This allows for later diffs to not fail CI

This handles the existing and later workflows.

This work will be reverted later in https://phab.comm.dev/D4735

Depends on D4685

Test Plan

Blob, backup, and tunnelbroker CI gates pass

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• jon created this revision.Aug 3 2022, 11:22 PM
Herald added subscribers: • adrian, tomek, ashoat. · View Herald TranscriptAug 3 2022, 11:22 PM
• jon added a child revision: D4671: [Services] Update tunnelbroker Dockerfile & cmake.Aug 3 2022, 11:23 PM
• jon mentioned this in D4735: [Services] Remove build_services compatibility logic.Aug 3 2022, 11:29 PM
Harbormaster completed remote builds in B11102: Diff 15293.Aug 3 2022, 11:38 PM
• jon requested review of this revision.Aug 3 2022, 11:38 PM
• jon added a comment.Aug 3 2022, 11:57 PM

This is undone in https://phab.comm.dev/D4735

• jon edited the summary of this revision. (Show Details)Aug 3 2022, 11:57 PM
• abosh requested changes to this revision.Aug 4 2022, 10:29 AM
• abosh added inline comments.
services/lib/docker/build_service.sh
11

Should these be escaped to avoid confusion with the regex? I know the -r flag isn't set but sed can be weird. The same question applies to line 27.

This revision now requires changes to proceed.Aug 4 2022, 10:29 AM
ashoat added inline comments.Aug 5 2022, 9:04 AM
services/lib/docker/build_service.sh
8

It's weird that we call this entire if block a Folly hack where it seems that much of it isn't really related to the Folly hack

ashoat added inline comments.Aug 5 2022, 9:06 AM
services/lib/docker/build_service.sh
8

(Ignore this, it's undone in D4735 anyways)

• jon updated this revision to Diff 15369.Aug 5 2022, 11:35 AM

Rebase

Harbormaster completed remote builds in B11165: Diff 15369.Aug 5 2022, 11:47 AM
• jon marked 2 inline comments as done.Aug 5 2022, 5:06 PM
• jon added inline comments.
services/lib/docker/build_service.sh
11

I would say no, this is pretty canonical GNU sed usage

• abosh accepted this revision.Aug 8 2022, 7:50 AM
This revision is now accepted and ready to land.Aug 8 2022, 7:50 AM
Closed by commit rCOMM1ce887c5239d: [Services] Allow for docker paths and system packages (authored by • jon). · Explain WhyAug 8 2022, 11:34 AM
This revision was automatically updated to reflect the committed changes.
• jon added a commit: rCOMM1ce887c5239d: [Services] Allow for docker paths and system packages.
• jon mentioned this in rCOMM8d3670c56c1a: [Services] Remove build_services compatibility logic.Aug 8 2022, 1:45 PM

Revision Contents
Changeset List

PathSize
services/
lib/
docker/
35 lines

Diff 15293

View Options

services/lib/docker/build_service.sh

Loading...