A leftover, it will be reverted, thx.

Sure, no problem.

It's fixed in D4974

It's a hack, I had to do this, because when I wanted to use rx without take, rust would complain that I couldn't use it as mut (IIRC because it's a struct member).

If having a sender and receiver is intrinsic (e.g. the existence of it requires these things to be true) to a bidiclient, then I don't think we should have option on each field. Instead we should use Option<BidiClient> to see if it's been initialized. If you did get Some(BidiClient), then you can assume that it has valid sender/receiver fields.

Little more concise way to express this, and avoids acquiring a lock twice

If you do the Option<BidiClient> comment I did above, then you would just write:

fn is_initialized() -> bool {
  CLIENT.lock().expect("access client").is_some()
}

We should be using a logging utilities for this. Then we can control the noise level with RUST_LOG

would be nice for the expect to be a bit more descriptive. If we do see failures, then just "access client" being copy pasted every doesn't help too much

I initially wanted to do it like this but it didn't work for some reason. I'll try to do this but wouldn't give it a high prio. https://linear.app/comm/issue/ENG-1716/try-using-option-higher-in-hierarchy

https://linear.app/comm/issue/ENG-1716/try-using-option-higher-in-hierarchy

fixed in D4974

I couldn't make it work, they simply will not show on the screen. https://linear.app/comm/issue/ENG-1717/use-tracing-utilities-instead-of-println

I think in the error message there is a line number so that's helpful enough. Also, we're getting rid of expects and unwraps later in the stack.