Depends on D4946
Ad data chunks may be any bytes, not only utf8 or something, we should store them in the vectors of bytes, not in strings (it's not c++ where std::string is able to store any bytes).
Differential D4972
[services] Backup - Connect to Blob - Use vector of bytes instead of String for data chunks Authored by • karol on Aug 29 2022, 8:38 AM.
Details Depends on D4946 Ad data chunks may be any bytes, not only utf8 or something, we should store them in the vectors of bytes, not in strings (it's not c++ where std::string is able to store any bytes). you could try to send some non-utf-8 bytes and see what happens. I didn't have time to do this and this diff is more based on my prior experiences and is more "preventing".
Diff Detail
Event TimelineComment Actions
If you have a way of verifying that the code works, it should be quick to modify it to send non-utf8. If you don't have that, you should create it. Comment Actions Abandoning this stack in favor of the new one that starts @ D5002. All the comments have been either addressed inline or in the new stack. |