Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
This diff increases the indentation by a lot. Could you find a way to refactor the code? (using e.g. early exits, match statements, etc.)
| services/backup/blob_client/src/put_client.rs | ||
|---|---|---|
| 47–59 | This can be simplified to be a single match | |
| 66 | Do we really want to always execute error!("could not access error messages") code? Was this behavior tested? | |
| 87–88 | Can we return a value from block_on? | |
| 119–121 | ||
Comment Actions
Abandoning this stack in favor of the new one that starts @ D5002.
All the comments have been either addressed inline or in the new stack.