Page MenuHomePhabricator

Rename deviceIDTypes to deviceTypes, add comments
ClosedPublic

Authored by inka on Oct 5 2022, 5:57 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 26, 10:25 PM
Unknown Object (File)
Tue, Nov 26, 9:36 PM
Unknown Object (File)
Mon, Nov 25, 10:32 PM
Unknown Object (File)
Mon, Nov 25, 10:32 PM
Unknown Object (File)
Mon, Nov 25, 8:04 PM
Unknown Object (File)
Mon, Nov 25, 8:03 PM
Unknown Object (File)
Sun, Nov 24, 12:25 PM
Unknown Object (File)
Sat, Nov 23, 7:34 AM

Details

Summary

As suggested in comments on D4754, deviceIDTypes has been renamed to deviceTypes. The comments are needed because we have a logical dependency between these functions and variables that are not enforced by the code.

Test Plan

See with Redux DevTools that device ID is still present in Redux store on web

Diff Detail

Repository
rCOMM Comm
Branch
inka/deviceID_rs_rebuild
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

inka retitled this revision from Rename deviceIDTypes to deviceTypes to Rename deviceIDTypes to deviceTypes, add comments.Oct 5 2022, 6:03 AM
inka edited the summary of this revision. (Show Details)
inka requested review of this revision.Oct 5 2022, 6:08 AM

defer to someone else for js

services/tunnelbroker/src/Constants.h
51–54

We should eventually consolidate shared logic, and avoid it getting out-of-sync.

This revision is now accepted and ready to land.Oct 6 2022, 1:41 AM

@jon I didn't add you, Herald did. Also: we (me, @tomek and @ashoat) talked about what should be done about this keeping in sync, but because all these are in different languages, and we don't expect this to change much, it has been decided that for now it would be too much work to have this be synced automatically.

inka edited the summary of this revision. (Show Details)

cherry pick