As suggested in comments on D4754, deviceIDTypes has been renamed to deviceTypes. The comments are needed because we have a logical dependency between these functions and variables that are not enforced by the code.
Details
Details
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- inka/deviceID_rs_rebuild
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
defer to someone else for js
services/tunnelbroker/src/Constants.h | ||
---|---|---|
51–54 | We should eventually consolidate shared logic, and avoid it getting out-of-sync. |
Comment Actions
@jon I didn't add you, Herald did. Also: we (me, @tomek and @ashoat) talked about what should be done about this keeping in sync, but because all these are in different languages, and we don't expect this to change much, it has been decided that for now it would be too much work to have this be synced automatically.