Page MenuHomePhabricator
Differential D5410

[native] [17/34] ReactNav6: Fix up BaseNavigationContainerInterface type
ClosedPublic
Actions

Authored by ashoat on Oct 20 2022, 6:15 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 28, 11:33 PM
Unknown Object (File)
Thu, Nov 28, 11:33 PM
Unknown Object (File)
Nov 15 2024, 5:43 PM
Unknown Object (File)
Nov 11 2024, 1:51 AM
Unknown Object (File)
Oct 15 2024, 10:11 AM
Unknown Object (File)
Oct 14 2024, 9:42 PM
Unknown Object (File)
Oct 6 2024, 1:45 AM
Unknown Object (File)
Oct 6 2024, 1:44 AM
View All Files
Subscribers
• abosh

Details

Reviewers
atul
tomek
bartek
Commits
rCOMM64e53ff70c2b: [native] [17/34] ReactNav6: Fix up BaseNavigationContainerInterface type
Summary

This type was missing several functions that are present upstream.

Note that we are still missing the EventEmitter types that are present in the upstream TypeScript types. Turns out those are actually mistyped on the TypeScript side... more context here.

Depends on D5409

Test Plan

Flow + ran the app on my phone and played around with it

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
native/
flow-typed/
npm/
@react-navigation/
7 lines
7 lines
7 lines
7 lines
7 lines

Diff 17688

View Options

native/flow-typed/npm/@react-navigation/bottom-tabs_v5.x.x.js

Loading...
View Options

native/flow-typed/npm/@react-navigation/devtools_v5.x.x.js

Loading...
View Options

native/flow-typed/npm/@react-navigation/material-top-tabs_v5.x.x.js

Loading...
View Options

native/flow-typed/npm/@react-navigation/native_v5.x.x.js

Loading...
View Options

native/flow-typed/npm/@react-navigation/stack_v5.x.x.js

Loading...