Page MenuHomePhabricator
Differential D5426

[native] [33/34] ReactNav6: Update HeaderTitle to use flex positioning
ClosedPublic
Actions

Authored by ashoat on Oct 20 2022, 6:21 AM.
Tags
None
Referenced Files
F3249210: D5426.id17704.diff
Fri, Nov 15, 12:40 PM
F3248608: D5426.diff
Fri, Nov 15, 10:23 AM
Unknown Object (File)
Mon, Nov 11, 4:40 PM
Unknown Object (File)
Mon, Nov 11, 1:51 AM
Unknown Object (File)
Mon, Oct 28, 5:08 AM
Unknown Object (File)
Mon, Oct 28, 5:08 AM
Unknown Object (File)
Mon, Oct 28, 5:05 AM
Unknown Object (File)
Sep 26 2024, 7:08 PM
View All Files
Subscribers
• abosh

Details

Reviewers
atul
tomek
bartek
Commits
rCOMMce393d6b5986: [native] [33/34] ReactNav6: Update HeaderTitle to use flex positioning
Summary

The relevant part here is actually just removing headerTitleContainerStyle... without that, the HeaderTitle was way too narrow.

But I also did the work to forward props along since it seemed like the right thing.

Context on change here.

Depends on D5425

Test Plan

Flow + ran the app on my phone and played around with it

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat created this revision.Oct 20 2022, 6:21 AM
Herald added a subscriber: • abosh. · View Herald TranscriptOct 20 2022, 6:21 AM
ashoat added a child revision: D5427: [native] [34/34] ReactNav6: Update package versions.Oct 20 2022, 6:21 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Oct 20 2022, 6:43 AM
Harbormaster failed remote builds in B12913: Diff 17704!
ashoat requested review of this revision.Oct 20 2022, 7:26 AM

Build failures are caused by use of @react-navigation/elements in D5420, which isn't introduced until D5427. Sorry!!

atul accepted this revision.Oct 20 2022, 1:20 PM
This revision is now accepted and ready to land.Oct 20 2022, 1:20 PM
This revision was landed with ongoing or failed builds.Oct 20 2022, 1:48 PM
Closed by commit rCOMMce393d6b5986: [native] [33/34] ReactNav6: Update HeaderTitle to use flex positioning (authored by ashoat). · Explain Why
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMMce393d6b5986: [native] [33/34] ReactNav6: Update HeaderTitle to use flex positioning.

Revision Contents
Changeset List

PathSize
native/
chat/
7 lines
41 lines

Diff 17789

View Options

native/chat/chat.react.js

Loading...
View Options

native/chat/message-list-header-title.react.js

Loading...