Page MenuHomePhabricator
Differential D5611

[native] Fix appearance of `TabNavigator` in light mode
ClosedPublic
Actions

Authored by atul on Nov 10 2022, 5:21 PM.
Tags
None
Referenced Files
F3518625: D5611.id18361.diff
Sun, Dec 22, 8:28 PM
F3516972: D5611.diff
Sun, Dec 22, 3:54 PM
Unknown Object (File)
Mon, Dec 9, 3:37 PM
Unknown Object (File)
Mon, Dec 9, 1:36 PM
Unknown Object (File)
Nov 2 2024, 11:10 PM
Unknown Object (File)
Oct 15 2024, 8:34 AM
Unknown Object (File)
Oct 12 2024, 4:07 AM
Unknown Object (File)
Oct 12 2024, 3:54 AM
View All 60 Files
Subscribers
ashoat

Details

Reviewers
tomek
marcin
ginsu
rohan
• abosh
varun
ashoat
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rCOMM078cd822453e: [native] Fix appearance of `TabNavigator` in light mode
Summary

Context: https://linear.app/comm/issue/ENG-2052/re-introduce-light-mode-in-native

The backgroundColor of TabNavigator was previously hardcoded to a dark value that looked fine in dark mode but looked broken in light mode.

This diff sets the backgroundColor to tabBarBackground which will adapt based on the theme.

Test Plan

Before:

214ce5.png (1×710 px, 303 KB)

After:

85d343.png (1×706 px, 305 KB)

Things look as expected.

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Nov 10 2022, 5:21 PM
Herald added a subscriber: ashoat. · View Herald TranscriptNov 10 2022, 5:21 PM
atul edited the test plan for this revision. (Show Details)Nov 10 2022, 5:22 PM
Harbormaster completed remote builds in B13386: Diff 18361.Nov 10 2022, 5:34 PM
atul requested review of this revision.Nov 10 2022, 5:34 PM
ashoat added inline comments.Nov 10 2022, 6:48 PM
native/navigation/tab-navigator.react.js
94

Think this should be changed in light mode, it's kinda hard to tell which tab is open. Not sure if that's meant for a separate diff tho

atul added inline comments.Nov 10 2022, 7:01 PM
native/navigation/tab-navigator.react.js
94

Yeah agree that change is in: https://phab.comm.dev/D5615

ginsu accepted this revision.Nov 11 2022, 8:52 AM

great fix

This revision is now accepted and ready to land.Nov 11 2022, 8:52 AM
atul added a reviewer: Restricted Owners Package.Nov 11 2022, 8:53 AM
This revision now requires review to proceed.Nov 11 2022, 8:53 AM
ashoat accepted this revision.Nov 11 2022, 1:02 PM
This revision is now accepted and ready to land.Nov 11 2022, 1:02 PM
Closed by commit rCOMM078cd822453e: [native] Fix appearance of `TabNavigator` in light mode (authored by atul). · Explain WhyNov 11 2022, 1:09 PM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM078cd822453e: [native] Fix appearance of `TabNavigator` in light mode.

Revision Contents
Changeset List

PathSize
native/
navigation/
26 lines

Diff 18361

View Options

native/navigation/tab-navigator.react.js

Loading...