Page MenuHomePhabricator
Differential D5746

[lib] introduced shimUnsupportedMessageInfo function to reaction message spec
ClosedPublic
Actions

Authored by ginsu on Nov 28 2022, 3:54 PM.
Tags
None
Referenced Files
F3380656: D5746.id19409.diff
Thu, Nov 28, 1:13 AM
F3380508: D5746.id18900.diff
Thu, Nov 28, 12:13 AM
Unknown Object (File)
Mon, Nov 25, 3:54 AM
Unknown Object (File)
Mon, Nov 25, 3:54 AM
Unknown Object (File)
Sun, Nov 24, 11:54 AM
Unknown Object (File)
Sun, Nov 24, 6:44 AM
Unknown Object (File)
Sun, Nov 24, 6:25 AM
Unknown Object (File)
Wed, Nov 13, 10:29 PM
View All Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
tomek
rohan
atul
Commits
rCOMM2dfff91655d0: [lib] introduced shimUnsupportedMessageInfo function to reaction message spec
Summary

introduced shimUnsupportedMessageInfo function in reaction message spec. shimUnsupportedMessageInfo checks if the user is below the min code version which supports reactions and if that is the case returns an unsupported message info. The robotext for this unsupported message info is "user sent a reaction".

Before landing this diff I will go back and change the minCodeVersion to be accurate to where we currently are

Depends on D5690
Linear Task: ENG-2245

Test Plan

Please see the screenshots below to see what happens when the reaction message is "unsupported"

What it looks like on the app

Screenshot 2022-11-28 at 11.24.26 AM.png (1×1 px, 826 KB)

The messageInfo object

Screenshot 2022-11-28 at 11.25.24 AM.png (568×846 px, 262 KB)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Nov 28 2022, 3:54 PM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptNov 28 2022, 3:54 PM
ginsu edited the summary of this revision. (Show Details)Nov 28 2022, 4:02 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: tomek, rohan, atul.
ginsu added a parent revision: D5690: [lib] introduced reaction message spec boilerplate.
ginsu attached a referenced file: F263890: Screenshot 2022-11-28 at 11.25.24 AM.png. (Show Details)
ginsu attached a referenced file: F263891: Screenshot 2022-11-28 at 11.24.26 AM.png. (Show Details)
Harbormaster completed remote builds in B13808: Diff 18900.Nov 28 2022, 4:08 PM
ginsu requested review of this revision.Nov 28 2022, 4:08 PM
atul retitled this revision from [lib] introduced shimUnsupportedMessageInfo functino to reaction message spec to [lib] introduced shimUnsupportedMessageInfo function to reaction message spec.Nov 28 2022, 4:09 PM
ginsu updated this revision to Diff 18901.Nov 28 2022, 4:09 PM

rebase

ginsu edited the test plan for this revision. (Show Details)Nov 28 2022, 4:15 PM
atul accepted this revision.Nov 28 2022, 4:21 PM
This revision is now accepted and ready to land.Nov 28 2022, 4:21 PM
Harbormaster completed remote builds in B13809: Diff 18901.Nov 28 2022, 4:23 PM
ginsu updated this revision to Diff 19406.Dec 15 2022, 11:29 AM

rebase before landing

Harbormaster completed remote builds in B14185: Diff 19406.Dec 15 2022, 11:43 AM
Closed by commit rCOMM2dfff91655d0: [lib] introduced shimUnsupportedMessageInfo function to reaction message spec (authored by ginsu). · Explain WhyDec 15 2022, 11:55 AM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM2dfff91655d0: [lib] introduced shimUnsupportedMessageInfo function to reaction message spec.
ginsu added a comment.Dec 15 2022, 11:58 AM

Before landing this diff I will go back and change the minCodeVersion to be accurate to where we currently are

Will create a separate diff today/tomorrow to address this

tomek added a comment.Dec 16 2022, 2:54 AM
In D5746#176062, @ginsu wrote:

Before landing this diff I will go back and change the minCodeVersion to be accurate to where we currently are

Will create a separate diff today/tomorrow to address this

It is usually better to wait with setting the version to just before the release. Even if we set the current version now, we might decide later to release a new bugfix and we would have to remember about updating this again to avoid releasing the feature by mistake.

Revision Contents
Changeset List

PathSize
lib/
shared/
messages/
25 lines

Diff 18900

View Options

lib/shared/messages/reaction-message-spec.js

Loading...