Page MenuHomePhabricator
Differential D5752

[lib] introduce SendReactionMessageRequest type to message types
ClosedPublic
Actions

Authored by ginsu on Nov 29 2022, 6:50 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 24, 7:56 AM
Unknown Object (File)
Sun, Nov 24, 7:28 AM
Unknown Object (File)
Sun, Nov 24, 6:40 AM
Unknown Object (File)
Sun, Nov 24, 6:39 AM
Unknown Object (File)
Sun, Nov 24, 4:46 AM
Unknown Object (File)
Mon, Nov 4, 10:36 PM
Unknown Object (File)
Mon, Nov 4, 3:49 PM
Unknown Object (File)
Mon, Nov 4, 3:49 PM
View All Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
atul
rohan
tomek
ashoat
Commits
rCOMM9eff6791baaf: [lib] introduce SendReactionMessageRequest type to message types
Summary

introduce SendReactionMessageRequest type to message types. This type will be needed in the reactionMessageCreationResponder

Test Plan

flow and this will be further tested in subsequent diffs

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Nov 29 2022, 6:50 AM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptNov 29 2022, 6:50 AM
ginsu added reviewers: atul, rohan, tomek.Nov 29 2022, 6:52 AM
ginsu mentioned this in D5749: [keyserver] introduced reactionMessageCreationResponder function to message responders.Nov 29 2022, 7:01 AM
Harbormaster completed remote builds in B13836: Diff 18954.Nov 29 2022, 7:04 AM
ginsu requested review of this revision.Nov 29 2022, 7:04 AM
ginsu added a child revision: D5749: [keyserver] introduced reactionMessageCreationResponder function to message responders.Nov 29 2022, 11:47 AM
ashoat accepted this revision.Nov 30 2022, 7:00 AM

Don't think this needed to be a separate diff

tomek accepted this revision.Nov 30 2022, 10:15 AM
tomek added inline comments.
lib/types/message-types.js
549 ↗(On Diff #18954)

What would it mean if a request with reaction = null was sent?

ginsu added inline comments.Nov 30 2022, 10:38 AM
lib/types/message-types.js
549 ↗(On Diff #18954)

I was thinking that if a reaction is null it would mean that the user unliked/unreacted to a message

atul accepted this revision.Nov 30 2022, 3:19 PM
This revision is now accepted and ready to land.Nov 30 2022, 3:19 PM
tomek added inline comments.Dec 1 2022, 1:51 AM
lib/types/message-types.js
549 ↗(On Diff #18954)

This might be ok for now, but what will happen when a user has more reactions? Would null unset all of them? It seems like we should rethink our approach regarding removing reactions.

Thinking about it now is a good idea, because introducing API that has to be changed soon and requires checking client version increases complexity.

ginsu updated this revision to Diff 19116.Dec 2 2022, 2:29 PM

rebase with unsettingReaction field

Harbormaster completed remote builds in B13950: Diff 19116.Dec 2 2022, 2:40 PM
ginsu updated this revision to Diff 19143.Dec 5 2022, 1:26 PM

rebase with action field

Harbormaster completed remote builds in B13970: Diff 19143.Dec 5 2022, 1:38 PM
ginsu added a child revision: D5817: [lib] added reaction type to local unshim types.Dec 5 2022, 7:17 PM
ginsu updated this revision to Diff 19229.Dec 7 2022, 10:50 AM

rebase before landing

Harbormaster completed remote builds in B14047: Diff 19229.Dec 7 2022, 11:00 AM
Closed by commit rCOMM9eff6791baaf: [lib] introduce SendReactionMessageRequest type to message types (authored by ginsu). · Explain WhyDec 7 2022, 11:04 AM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM9eff6791baaf: [lib] introduce SendReactionMessageRequest type to message types.

Revision Contents
Changeset List

PathSize
lib/
types/
7 lines

Diff 19231

View Options

lib/types/message-types.js

Loading...