Page MenuHomePhabricator
Differential D5750

[lib/keyserver] included reactionMessageCreationResponder to the JSON endpoints
ClosedPublic
Actions

Authored by ginsu on Nov 28 2022, 4:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 9, 11:29 AM
Unknown Object (File)
Wed, Nov 6, 7:05 PM
Unknown Object (File)
Wed, Nov 6, 7:05 PM
Unknown Object (File)
Mon, Oct 28, 8:21 AM
Unknown Object (File)
Wed, Oct 16, 3:43 PM
Unknown Object (File)
Oct 13 2024, 10:09 AM
Unknown Object (File)
Sep 28 2024, 10:59 AM
Unknown Object (File)
Sep 28 2024, 10:59 AM
View All Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
atul
rohan
tomek
ashoat
Commits
rCOMMbe008d2de38b: [lib/keyserver] included reactionMessageCreationResponder to the JSON endpoints
Summary

added reactionMessageCreationResponder to the JSON endpoints. This will be used to connect reactionMessageCreationResponder in keyserver to sendReactionMessage in lib

Depends on D5749

Linear Task: ENG-2250

Test Plan

This will be tested further in subsequent diffs. But ran this locally on web/mobile and nothing crashed. Also helped me get to the point where I could push a reaction message into the DB (see screenshot below)

Screenshot 2022-11-28 at 7.16.55 PM.png (2×3 px, 1 MB)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Nov 28 2022, 4:41 PM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptNov 28 2022, 4:41 PM
ginsu edited the summary of this revision. (Show Details)Nov 28 2022, 4:44 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, rohan, tomek.
ginsu edited the summary of this revision. (Show Details)
ginsu attached a referenced file: F264011: Screenshot 2022-11-28 at 7.16.55 PM.png. (Show Details)
Harbormaster completed remote builds in B13813: Diff 18905.Nov 28 2022, 4:52 PM
ginsu requested review of this revision.Nov 28 2022, 4:52 PM
ashoat accepted this revision.Nov 28 2022, 7:05 PM
tomek accepted this revision.Nov 29 2022, 4:34 AM
atul accepted this revision.Nov 30 2022, 3:19 PM
This revision is now accepted and ready to land.Nov 30 2022, 3:19 PM
ginsu added a child revision: D5770: [lib] introduce sendReactionMessage to message actions.Nov 30 2022, 3:49 PM
ginsu edited the summary of this revision. (Show Details)
ginsu added a parent revision: D5749: [keyserver] introduced reactionMessageCreationResponder function to message responders.
ginsu updated this revision to Diff 19685.EditedDec 19 2022, 11:06 AM
ginsu edited the test plan for this revision. (Show Details)

fixed merge conflicts with kamils changes. Synced with Kamil to figure out the required policies for creating a reaction message

Harbormaster completed remote builds in B14432: Diff 19685.Dec 19 2022, 11:31 AM
ginsu updated this revision to Diff 19897.Dec 20 2022, 3:24 PM

rebase before landing

Harbormaster completed remote builds in B14591: Diff 19897.Dec 20 2022, 3:38 PM
Closed by commit rCOMMbe008d2de38b: [lib/keyserver] included reactionMessageCreationResponder to the JSON endpoints (authored by ginsu). · Explain WhyDec 20 2022, 4:06 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMbe008d2de38b: [lib/keyserver] included reactionMessageCreationResponder to the JSON endpoints.

Revision Contents
Changeset List

PathSize
keyserver/
src/
5 lines
lib/
types/
1 line

Diff 19685

View Options

keyserver/src/endpoints.js

Loading...
View Options

lib/types/endpoints.js

Loading...