Differential D6179

[services][backup] Add database helpers
ClosedPublic
Actions

Authored by bartek on Jan 5 2023, 5:12 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Dec 9, 4:46 AM

	Unknown Object (File)
	Fri, Dec 6, 9:48 PM

	Unknown Object (File)
	Sun, Dec 1, 4:01 AM

	Unknown Object (File)
	Sat, Nov 30, 12:57 AM

	Unknown Object (File)
	Sat, Nov 30, 12:57 AM

	Unknown Object (File)
	Sat, Nov 30, 12:57 AM

	Unknown Object (File)
	Sat, Nov 30, 12:57 AM

	Unknown Object (File)
	Sat, Nov 30, 12:57 AM

Subscribers

Details

Reviewers

varun
tomek
• jon
• max

Commits

rCOMM3a30a794af17: [services][backup] Add database helpers

Summary

Added error structures and helper methods for database client. These are mostly copy-pasted from blob and identity services. In the future I plan to extract these to some shared rust library: https://linear.app/comm/issue/ENG-2311/shared-rust-code-across-services

Depends on D6178

Test Plan

These methods are tested altogether with the database code. However, it might be worth adding some unit tests as a follow-up task.

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Jan 5 2023, 5:12 AM

bartek held this revision as a draft.

Herald added subscribers: atul, ashoat. · View Herald TranscriptJan 5 2023, 5:12 AM

bartek added a child revision: D6180: [services][backup] Add BackupItem database methods.Jan 5 2023, 5:15 AM

bartek published this revision for review.Jan 5 2023, 5:20 AM

Harbormaster completed remote builds in B15122: Diff 20617.Jan 5 2023, 5:26 AM

Rebase

Harbormaster completed remote builds in B15150: Diff 20658.Jan 9 2023, 2:58 AM

Rebase

Harbormaster completed remote builds in B15188: Diff 20700.Jan 9 2023, 7:33 AM

tomek accepted this revision.Jan 9 2023, 8:17 AM

varun accepted this revision.Jan 9 2023, 7:29 PM

This revision is now accepted and ready to land.Jan 9 2023, 7:29 PM

Rebase

Harbormaster completed remote builds in B15284: Diff 20843.Jan 12 2023, 1:09 AM

Closed by commit rCOMM3a30a794af17: [services][backup] Add database helpers (authored by bartek). · Explain WhyJan 13 2023, 9:04 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM3a30a794af17: [services][backup] Add database helpers.

Revision Contents
Changeset List

Path

Size

services/

backup/

src/

114 lines

Diff 20658

services/backup/src/database.rs

Loading...