Page MenuHomePhabricator
Differential D6204

[services][backup] AddAttachments 1/4 - create handler module
ClosedPublic
Actions

Authored by bartek on Jan 9 2023, 12:00 PM.
Tags
None
Referenced Files
F3525668: D6204.diff
Mon, Dec 23, 6:06 PM
Unknown Object (File)
Fri, Dec 20, 3:31 AM
Unknown Object (File)
Thu, Nov 28, 11:31 AM
Unknown Object (File)
Thu, Nov 28, 4:07 AM
Unknown Object (File)
Thu, Nov 28, 4:07 AM
Unknown Object (File)
Thu, Nov 28, 4:07 AM
Unknown Object (File)
Thu, Nov 28, 4:07 AM
Unknown Object (File)
Thu, Nov 28, 4:06 AM
View All Files
Subscribers
ashoat
atul

Details

Reviewers
varun
tomek
• jon
• max
Commits
rCOMM93b265f7635e: [services][backup] AddAttachments 1/4 - create handler module
Summary

Created module for AddAttachments endpoint and added its invocation in the grpc handler.

Depends on D6203

Test Plan

Service builds and starts. This code has no logic yet.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek created this revision.Jan 9 2023, 12:00 PM
bartek held this revision as a draft.
Herald added subscribers: atul, ashoat. · View Herald TranscriptJan 9 2023, 12:00 PM
bartek added a child revision: D6205: [services][backup] AddAttachments 2/4 - holders string utils.Jan 9 2023, 12:13 PM
Harbormaster completed remote builds in B15211: Diff 20736.Jan 9 2023, 12:15 PM
bartek published this revision for review.Jan 9 2023, 12:32 PM
tomek accepted this revision.Jan 11 2023, 5:31 AM
This revision is now accepted and ready to land.Jan 11 2023, 5:31 AM
bartek updated this revision to Diff 20883.Jan 12 2023, 9:18 AM
  • Removed logging of user_id
  • Cleaned up log message a bit
Harbormaster completed remote builds in B15308: Diff 20883.Jan 12 2023, 9:33 AM
bartek updated this revision to Diff 21086.Jan 19 2023, 9:40 AM

Rebase

Harbormaster completed remote builds in B15464: Diff 21086.Jan 19 2023, 9:59 AM
Closed by commit rCOMM93b265f7635e: [services][backup] AddAttachments 1/4 - create handler module (authored by bartek). · Explain WhyJan 19 2023, 10:07 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMM93b265f7635e: [services][backup] AddAttachments 1/4 - create handler module.

Revision Contents
Changeset List

PathSize
services/
backup/
src/
service/
handlers/
11 lines
22 lines

Diff 20736

View Options

services/backup/src/service/handlers/add_attachments.rs

Loading...
View Options

services/backup/src/service/mod.rs

Loading...