[services][backup] CreateBackup 2/3 - handle non-data inputs
ClosedPublic
Actions

Authored by bartek on Jan 9 2023, 4:03 AM.

Details

Reviewers

varun
tomek
• jon
• max

Commits

rCOMM8280d98a3e8d: [services][backup] CreateBackup 2/3 - handle non-data inputs

Summary

This diff adds logic for processing non-data inputs (handler non-data-mode). After all of them are provided,
backup ID is generated and the put client is initialized and handler switches to "data mode", which is implemented in child diff.

Depends on D6197

Test Plan

The service builds and starts. Logic of this diff can be tested altogether with the child diff - see the description there.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Jan 9 2023, 4:03 AM

bartek held this revision as a draft.

Herald added subscribers: atul, ashoat. · View Herald TranscriptJan 9 2023, 4:03 AM

bartek added a child revision: D6199: [services][backup] CreateBackup 3/3 - handle chunks and finish.Jan 9 2023, 4:09 AM

Harbormaster completed remote builds in B15159: Diff 20670.Jan 9 2023, 4:16 AM

bartek published this revision for review.Jan 9 2023, 5:35 AM

Rebase

Harbormaster completed remote builds in B15194: Diff 20706.Jan 9 2023, 7:40 AM

tomek accepted this revision.Jan 11 2023, 5:00 AM

tomek added inline comments.

services/backup/src/service/handlers/create_backup.rs
56 ↗	(On Diff #20706)	Should we log user id?
142–143 ↗	(On Diff #20706)	It seems like we can conclude that we're in data mode just by checking if `blob_client` is present. But maybe it will change in the future diffs.