Page MenuHomePhabricator

[services][backup] LogItem size utilities
ClosedPublic

Authored by bartek on Jan 9 2023, 11:57 AM.
Tags
None
Referenced Files
F3490596: D6203.diff
Wed, Dec 18, 4:52 PM
Unknown Object (File)
Tue, Dec 3, 5:42 AM
Unknown Object (File)
Sat, Nov 30, 1:04 AM
Unknown Object (File)
Thu, Nov 28, 11:31 AM
Unknown Object (File)
Thu, Nov 28, 11:31 AM
Unknown Object (File)
Nov 10 2024, 2:00 PM
Unknown Object (File)
Nov 8 2024, 5:02 AM
Unknown Object (File)
Nov 8 2024, 5:02 AM
Subscribers

Details

Summary

We need a way to determine if given log item doesn't exceed DynamoDB item limit. See C++ counterpart.

This probably isn't the best solution as stated in https://linear.app/comm/issue/ENG-1336/avoid-hardcoding-database-items-fields-names but for now I'm trying to keep parity with the C++ way.

Depends on D6199

Test Plan

These will be tested with the AddAttachments and SendLog endpoints. I'm wondering if adding unit tests is worth doing here.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage