Page MenuHomePhabricator

[services][backup] AddAttachments 4/4 - moving to blob
ClosedPublic

Authored by bartek on Jan 9 2023, 12:29 PM.
Tags
None
Referenced Files
F3491711: D6207.diff
Wed, Dec 18, 8:01 PM
Unknown Object (File)
Sat, Nov 30, 9:50 PM
Unknown Object (File)
Sat, Nov 30, 4:04 PM
Unknown Object (File)
Thu, Nov 28, 11:33 AM
Unknown Object (File)
Thu, Nov 28, 11:33 AM
Unknown Object (File)
Thu, Nov 28, 11:32 AM
Unknown Object (File)
Thu, Nov 28, 11:32 AM
Unknown Object (File)
Thu, Nov 28, 11:32 AM
Subscribers

Details

Summary

This implements the last part of the AddAttachments endpoint - moving log item storage to blob service when it's too large.

Depends on D6206

Test Plan
  1. Manually created large log item, ensured that it's slightly less than 400kb.
  2. Called AddAttachments providing a long attachments holder string.
  3. Ensured Blob service got called and the log was uploaded & database entity was updated.

The backup service integration tests cover this case, but this needs remaining endpoints to be implemented.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek held this revision as a draft.
bartek published this revision for review.Jan 9 2023, 12:37 PM
This revision is now accepted and ready to land.Jan 11 2023, 5:55 AM

Fixed holder instead of log hash being provided to put client