Details

Reviewers

varun
tomek
• jon
• max

Commits

rCOMM00e7837a8979: [services][backup] Add Put client convenience helpers

Summary

Added some convenience helper functions to make it easier to works with Blob put client.
One method creates a simple put client, which is automatically supplied with holder and blob hash, where hash=holder.
These will be used later, especially when uploading logs, when such client is going to be instantiated
multiple times.

Depends on D6167

Test Plan

This code is tested in subsequent diffs where it is used in backup service ednpoints.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Jan 4 2023, 9:15 AM

bartek held this revision as a draft.

Herald added subscribers: atul, ashoat. · View Herald TranscriptJan 4 2023, 9:15 AM

bartek published this revision for review.Jan 4 2023, 9:25 AM

Harbormaster completed remote builds in B15089: Diff 20580.Jan 4 2023, 9:29 AM

Rebase

Harbormaster completed remote builds in B15113: Diff 20608.Jan 5 2023, 4:00 AM

bartek added a child revision: D6177: [services][backup] Add database client module.Jan 5 2023, 5:02 AM

Add blob_hash arg to start_simple_put_client to make it more flexible
Terminate early if data_exists

Harbormaster completed remote builds in B15147: Diff 20655.Jan 9 2023, 2:53 AM

tomek accepted this revision.Jan 9 2023, 6:59 AM

tomek added inline comments.

services/backup/src/blob/put_client.rs
144–147 ↗	(On Diff #20655)	Can't we use `put_data` here?

This revision is now accepted and ready to land.Jan 9 2023, 6:59 AM

bartek added inline comments.Jan 9 2023, 7:09 AM

services/backup/src/blob/put_client.rs
144–147 ↗	(On Diff #20655)	Not really, the `put_data` is for `PutRequestData::DataChunk(...)` and we have a `Holder` here. Fortunately, this function is the only place we put anything other than data chunks, so I wouldn't add any other convenience helpers.