Details

Reviewers

• przemek
michal
bartek

Commits

rCOMM770b6e37d0be: [web] Create a dummy topbar component

Summary

issue: https://linear.app/comm/issue/ENG-2739/move-navigationpanel-from-the-sidebar-to-a-top-bar
Adding a Topbar component that will contain the AppSwitcher and the navigation info bar. It will be displayed in the Inbox tab.
For now it displays "dummy", because adding it's contents requires a lot of changes to the code. So in the interest of keeping the diff small it has a dummy content for now.

Test Plan

Displayed it in the App component.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

inka created this revision.Jan 23 2023, 8:32 AM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptJan 23 2023, 8:32 AM

inka added a child revision: D6342: [web] Move AppSwitcher to web/topbar.Jan 23 2023, 8:36 AM

Harbormaster completed remote builds in B15536: Diff 21196.Jan 23 2023, 8:47 AM

inka requested review of this revision.Jan 23 2023, 8:47 AM

ashoat added inline comments.Jan 23 2023, 9:11 AM

web/topbar/topbar.react.js
9 ↗	(On Diff #21196)	Always use `$ReadOnly` if possible!

Make props readonly

Harbormaster failed remote builds in B15543: Diff 21204!Jan 23 2023, 9:29 AM

Remove returning null from Topbar, when in settings tab. I changed the approach, and now it is handled by the parent. This provides a better separation of responsibilities

Harbormaster completed remote builds in B15543: Diff 21204.Jan 24 2023, 12:25 AM

Harbormaster completed remote builds in B15576: Diff 21240.Jan 24 2023, 12:34 AM

inka added inline comments.Jan 24 2023, 1:00 AM

web/topbar/topbar.react.js
11–13	This component will display the AppSwitcher, that will mostly stay the same. It'll change on it's own when user changes selected apps based on selectors.