Paths

Table of Contentst

Differential D6345

[web] Use app switcher in the topbar
ClosedPublic
Actions

Authored by inka on Jan 23 2023, 8:58 AM.

Tags

None

Referenced Files

	F3618085: D6345.diff
	Wed, Jan 1, 7:30 PM

	Unknown Object (File)
	Tue, Dec 31, 7:51 AM

	Unknown Object (File)
	Wed, Dec 18, 4:41 AM

	Unknown Object (File)
	Wed, Dec 11, 4:33 PM

	Unknown Object (File)
	Nov 26 2024, 10:36 AM

	Unknown Object (File)
	Nov 24 2024, 5:38 AM

	Unknown Object (File)
	Nov 23 2024, 7:11 PM

	Unknown Object (File)
	Nov 19 2024, 7:02 PM

Subscribers

Details

Reviewers

• przemek
michal
bartek

Commits

rCOMM5c087ebe0ed8: [web] Use app switcher in the topbar

Summary

issue: https://linear.app/comm/issue/ENG-2739/move-navigationpanel-from-the-sidebar-to-a-top-bar
Use AppSwitcher in Topbar. Now, that the AppSwitcher is inside of the Topbar, it can be made horizontal, and it can use the styles for a horizontal switcher. The styles for icons in the left-layout-aside.css are no longer needed,
because the other switcher doesn't display any icons.

Test Plan

use Topbar in App component, check that it displayes correctly.

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

inka created this revision.Jan 23 2023, 8:58 AM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptJan 23 2023, 8:58 AM

inka added a parent revision: D6344: [web] Remove navigation panel from LeftLayoutAside.Jan 23 2023, 8:59 AM

inka added a child revision: D6346: [web] Use SettingsSwitcher and Topbar.Jan 23 2023, 9:09 AM

Harbormaster completed remote builds in B15540: Diff 21201.Jan 23 2023, 9:12 AM

inka requested review of this revision.Jan 23 2023, 9:12 AM

Rebase

Harbormaster completed remote builds in B15577: Diff 21241.Jan 24 2023, 12:37 AM

bartek accepted this revision.Jan 26 2023, 5:32 AM

This revision is now accepted and ready to land.Jan 26 2023, 5:32 AM

Rebase

Harbormaster failed remote builds in B16411: Diff 22448!Feb 13 2023, 7:29 AM

Add .js to imports

Harbormaster completed remote builds in B16434: Diff 22471.Feb 13 2023, 9:43 AM

Rebase

Harbormaster completed remote builds in B16489: Diff 22536.Feb 14 2023, 3:22 AM

Closed by commit rCOMM5c087ebe0ed8: [web] Use app switcher in the topbar (authored by • InkaSokolowska). · Explain WhyFeb 14 2023, 5:02 AM

This revision was automatically updated to reflect the committed changes.

• InkaSokolowska added a commit: rCOMM5c087ebe0ed8: [web] Use app switcher in the topbar.

Revision Contents
Changeset List

Path

Size

web/

sidebar/

left-layout-aside.css

32 lines

topbar/

app-switcher.react.js

4 lines

topbar.react.js

7 lines

Diff 21241

web/sidebar/left-layout-aside.css

Loading...

web/topbar/app-switcher.react.js

Loading...

web/topbar/topbar.react.js

Loading...