Paths

Table of Contentst

Differential D6385

[backup-service] Propagate 'BlobClient' to handlers
ClosedPublic
Actions

Authored by bartek on Jan 25 2023, 2:23 AM.

Tags

None

Referenced Files

	F3502639: D6385.diff
	Fri, Dec 20, 4:31 AM

	Unknown Object (File)
	Wed, Nov 20, 4:07 PM

	Unknown Object (File)
	Nov 10 2024, 2:00 PM

	Unknown Object (File)
	Nov 9 2024, 10:25 AM

	Unknown Object (File)
	Nov 9 2024, 6:37 AM

	Unknown Object (File)
	Nov 9 2024, 6:28 AM

	Unknown Object (File)
	Nov 9 2024, 6:07 AM

	Unknown Object (File)
	Nov 9 2024, 5:55 AM

Subscribers

Details

Reviewers

varun
• jon
michal
tomek

Commits

rCOMM64cbee886c03: [backup-service] Propagate 'BlobClient' to handlers

Summary

Part of https://linear.app/comm/issue/ENG-2688/backup-service-reuse-single-blob-client-instance

Citing https://phab.comm.dev/D6167?id=20696#inline-41664 and Tonic docs - the Channel is encouraged to be cloned and so the BlobClient instance is.
I propagated it to all places where it would be needed, the same way as DynamoDB DatabaseClient. It's not yet used, though.

Depends on D6384

Test Plan

Backup service compiles.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Jan 25 2023, 2:23 AM

bartek held this revision as a draft.

Herald added subscribers: atul, ashoat. · View Herald TranscriptJan 25 2023, 2:23 AM

bartek added a child revision: D6386: [backup-service] Use shared 'BlobClient' in workers.Jan 25 2023, 2:28 AM

Harbormaster completed remote builds in B15625: Diff 21299.Jan 25 2023, 2:37 AM

bartek published this revision for review.Jan 25 2023, 2:45 AM

tomek accepted this revision.Jan 26 2023, 4:20 AM

This revision is now accepted and ready to land.Jan 26 2023, 4:20 AM

Closed by commit rCOMM64cbee886c03: [backup-service] Propagate 'BlobClient' to handlers (authored by bartek). · Explain WhyJan 31 2023, 2:23 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM64cbee886c03: [backup-service] Propagate 'BlobClient' to handlers.

Revision Contents
Changeset List

Path

Size

services/

backup/

src/

11 lines

service/

handlers/

add_attachments.rs

9 lines

create_backup.rs

8 lines

15 lines

6 lines

18 lines

Diff 21656

services/backup/src/main.rs

Loading...

services/backup/src/service/handlers/add_attachments.rs

Loading...

services/backup/src/service/handlers/create_backup.rs

Loading...

services/backup/src/service/handlers/pull_backup.rs

Loading...

services/backup/src/service/handlers/send_log.rs

Loading...

services/backup/src/service/mod.rs

Loading...