Page MenuHomePhabricator
Differential D6361

[web] Move code around to match the new code logic
ClosedPublic
Actions

Authored by inka on Jan 24 2023, 2:17 AM.
Tags
None
Referenced Files
Unknown Object (File)
Nov 18 2024, 3:56 AM
Unknown Object (File)
Nov 8 2024, 2:59 AM
Unknown Object (File)
Oct 28 2024, 7:04 AM
Unknown Object (File)
Oct 28 2024, 7:04 AM
Unknown Object (File)
Oct 28 2024, 7:04 AM
Unknown Object (File)
Oct 28 2024, 7:04 AM
Unknown Object (File)
Oct 28 2024, 7:03 AM
Unknown Object (File)
Oct 28 2024, 7:03 AM
View All Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
• przemek
michal
bartek
Commits
rCOMM4d3c891ce681: [web] Move code around to match the new code logic
Summary

issue: https://linear.app/comm/issue/ENG-2739/move-navigationpanel-from-the-sidebar-to-a-top-bar
Now that the SettingSwitcher is no longer in the sidebar, it's code had to be moved outside of web/sidebar. The styles in left-layout-aside.css were only used for SettingsSwticher (and horizontal NavigationPanel that is used only in SettingsSwitcher so the file could be renamed and also moved. NavigationPanel is used for SettingSwitcher and AppSwitcher, so only for navigation panels. Thus all of this code could be put into web/navigation-panels as well as the Topbar, that is a navigation panel (contains AppSwitcher and will contain the navigation state information).

Test Plan

Run web app, check that the top bar in Inbox, and the SettingSwitcher in Settings display correctly. Run flow check in web/.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

inka created this revision.Jan 24 2023, 2:17 AM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptJan 24 2023, 2:17 AM
inka edited the summary of this revision. (Show Details)Jan 24 2023, 2:18 AM
Harbormaster completed remote builds in B15579: Diff 21243.Jan 24 2023, 2:31 AM
inka requested review of this revision.Jan 24 2023, 2:31 AM
inka added a parent revision: D6346: [web] Use SettingsSwitcher and Topbar.Jan 24 2023, 2:42 AM
inka mentioned this in D6336: [web] Remove LeftLayoutAside.Jan 31 2023, 8:13 AM
inka updated this revision to Diff 21832.Feb 2 2023, 2:22 AM

Rebase

Harbormaster completed remote builds in B15990: Diff 21832.Feb 2 2023, 2:37 AM
michal accepted this revision.Feb 9 2023, 5:43 AM
This revision is now accepted and ready to land.Feb 9 2023, 5:43 AM
inka updated this revision to Diff 22452.Feb 13 2023, 7:18 AM

Rebase

Harbormaster failed remote builds in B16415: Diff 22452!Feb 13 2023, 7:32 AM
inka updated this revision to Diff 22540.Feb 14 2023, 2:38 AM

Rebase

Harbormaster completed remote builds in B16493: Diff 22540.Feb 14 2023, 3:35 AM
Closed by commit rCOMM4d3c891ce681: [web] Move code around to match the new code logic (authored by • InkaSokolowska). · Explain WhyFeb 14 2023, 5:02 AM
This revision was automatically updated to reflect the committed changes.
• InkaSokolowska added a commit: rCOMM4d3c891ce681: [web] Move code around to match the new code logic.

Revision Contents
Changeset List

Diff 21832

View Options

web/app.react.js

Loading...
View Options

web/navigation-panels/app-switcher.react.js

Loading...
View Options

web/navigation-panels/navigation-panel.react.js

Loading...
View Options

web/navigation-panels/settings-switcher.css

Loading...
View Options

web/navigation-panels/settings-switcher.react.js

Loading...
View Options

web/navigation-panels/topbar.css

Loading...
View Options

web/navigation-panels/topbar.react.js

Loading...
View Options

web/sidebar/left-layout-aside.css

Loading...
View Options

web/sidebar/navigation-panel.react.js

Loading...
View Options

web/sidebar/settings-switcher.react.js

Loading...
View Options

web/topbar/app-switcher.react.js

Loading...
View Options

web/topbar/topbar.css

Loading...
View Options

web/topbar/topbar.react.js

Loading...