Linear issue: https://linear.app/comm/issue/ENG-2631/drawer-sidebar-inside-of-community-picker
Adding the community drawer.
Adding the community drawer on native: D5723 and D5732
Details
Details
- Reviewers
• przemek michal ginsu tomek - Commits
- rCOMM2c5747dd7716: [web] Add community drawer
added community drawer to AppsDirectory, checked that it behaves as expected.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| web/sidebar/community-drawer-content.react.js | ||
|---|---|---|
| 39–41 ↗ | (On Diff #20676) | I'm a bit confused by index name, on callsites of toggleExpanded we always pass threadInfo.id to this function. Maybe we rename it to communityRootThreadId or something like that? I have limited understanding of that recursive data structure, but from what I've read we represent communities by threadIDs of their roots, right? |
| web/sidebar/community-drawer.react.js | ||
| 8–14 ↗ | (On Diff #20676) | Is there a reason we've introduce new component just for wrapping it in a Provider? |
| web/sidebar/community-drawer.react.js | ||
|---|---|---|
| 8–14 ↗ | (On Diff #20676) | It was mostly done to keep a similar structure to what we have on native, where the counterpart to CommunityDrawer : CommunityDrawerNavigator has a lot of logic. But I suppose Community Picker can be considered the counterpart to CommunityDrawerNavigator. I'll change that, thank you |
| web/sidebar/community-drawer.react.js | ||
|---|---|---|
| 4 ↗ | (On Diff #21675) | We definitely should as it provides types for AppState |