Page MenuHomePhabricator
Differential D6298

[2/n] Native Typeahead - Adding utility file and native regex
ClosedPublic
Actions

Authored by • przemek on Jan 18 2023, 8:50 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 8, 6:53 PM
Unknown Object (File)
Tue, Oct 29, 5:28 AM
Unknown Object (File)
Tue, Oct 29, 5:28 AM
Unknown Object (File)
Tue, Oct 29, 5:28 AM
Unknown Object (File)
Tue, Oct 29, 5:28 AM
Unknown Object (File)
Tue, Oct 29, 5:28 AM
Unknown Object (File)
Tue, Oct 29, 5:27 AM
Unknown Object (File)
Tue, Oct 29, 5:23 AM
View All Files
Subscribers
ashoat
atul
ginsu
inka
kamil
michal
tomek

Details

Reviewers
inka
ginsu
kamil
michal
tomek
Commits
rCOMM1685604c1512: [2/n] Native Typeahead - Adding utility file and native regex
Summary

Native regex is a little bit different than web one as there are no named captruing groups yet on native.
See: https://linear.app/comm/issue/ENG-2456/rewrite-typeahead-regexes-when-named-capturing-groups-are-released-for#comment-4bb6cf1e

Test Plan

Checked if regex works in online editor.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• przemek created this revision.Jan 18 2023, 8:50 AM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptJan 18 2023, 8:50 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Jan 18 2023, 8:54 AM
Harbormaster failed remote builds in B15437: Diff 21046!
Harbormaster completed remote builds in B15437: Diff 21046.Jan 20 2023, 5:39 AM
• przemek requested review of this revision.Jan 20 2023, 5:39 AM
ashoat added a comment.Jan 20 2023, 10:49 AM

Native regex is a little bit different than web one as there are no named captruing groups yet on native.
See: https://linear.app/comm/issue/ENG-2456/rewrite-typeahead-regexes-when-named-capturing-groups-are-released-for#comment-4bb6cf1e

I would add this as a code comment

inka accepted this revision.Jan 24 2023, 4:05 AM

I agree it would be good to leave a comment that web is on purposely different

This revision is now accepted and ready to land.Jan 24 2023, 4:05 AM
• przemek updated this revision to Diff 21261.Jan 24 2023, 12:29 PM

Added comment

Harbormaster failed remote builds in B15595: Diff 21261!Jan 24 2023, 12:35 PM
• przemek added a parent revision: D6297: [1/n] Native Typeahead - Moving type decalration to lib.Jan 24 2023, 1:07 PM
• przemek added a child revision: D6299: [3/n] Native Typeahead - Change max height of textarea.
Harbormaster completed remote builds in B15595: Diff 21261.Jan 24 2023, 2:59 PM
tomek accepted this revision.Jan 30 2023, 1:58 AM
ashoat added inline comments.Jan 30 2023, 9:53 AM
native/utils/typeahead-utils.js
6 ↗(On Diff #21261)

Typo

ashoat updated this revision to Diff 22164.Feb 6 2023, 5:40 PM

Fix typo

Harbormaster completed remote builds in B16200: Diff 22164.Feb 6 2023, 5:56 PM
ashoat updated this revision to Diff 22206.Feb 7 2023, 9:09 AM

Rebase

Harbormaster completed remote builds in B16235: Diff 22206.Feb 7 2023, 9:24 AM
Closed by commit rCOMM1685604c1512: [2/n] Native Typeahead - Adding utility file and native regex (authored by • przemek, committed by ashoat). · Explain WhyFeb 7 2023, 2:37 PM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM1685604c1512: [2/n] Native Typeahead - Adding utility file and native regex.

Revision Contents
Changeset List

PathSize
native/
utils/
11 lines

Diff 22164

View Options

native/utils/typeahead-utils.js

Loading...