Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Oct 29, 6:54 AM

	Unknown Object (File)
	Tue, Oct 29, 6:54 AM

	Unknown Object (File)
	Tue, Oct 29, 6:54 AM

	Unknown Object (File)
	Tue, Oct 29, 6:54 AM

	Unknown Object (File)
	Tue, Oct 29, 6:49 AM

	Unknown Object (File)
	Oct 2 2024, 1:01 PM

	Unknown Object (File)
	Sep 26 2024, 7:17 AM

	Unknown Object (File)
	Sep 26 2024, 7:17 AM

Subscribers

Details

Reviewers

inka
ginsu
kamil
michal
tomek

Commits

rCOMM9a5ad243ee32: [4.5/n] Native Typeahead - Refactoring to the common utility function

Summary

Refactoring some web code into lib function that will be used in native side as well.

Test Plan

Checked if app builds.
Checked if web typeahead still works corretly

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• przemek created this revision.Jan 27 2023, 6:24 AM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptJan 27 2023, 6:24 AM

• przemek added a parent revision: D6300: [4/n] Native Typeahead - Add user search and thread members to props.Jan 27 2023, 6:37 AM

• przemek added a child revision: D6367: [5/n] Native Typeahead - Add selection state to chat input bar.

Harbormaster completed remote builds in B15721: Diff 21442.Jan 27 2023, 6:38 AM

• przemek requested review of this revision.Jan 27 2023, 6:38 AM

tomek accepted this revision.Jan 30 2023, 2:51 AM

This revision is now accepted and ready to land.Jan 30 2023, 2:51 AM

Rebase

Harbormaster completed remote builds in B16239: Diff 22210.Feb 7 2023, 9:36 AM

Closed by commit rCOMM9a5ad243ee32: [4.5/n] Native Typeahead - Refactoring to the common utility function (authored by • przemek, committed by ashoat). · Explain WhyFeb 7 2023, 2:37 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM9a5ad243ee32: [4.5/n] Native Typeahead - Refactoring to the common utility function.

[4.5/n] Native Typeahead - Refactoring to the common utility function
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 22210

lib/shared/typeahead-utils.js

web/utils/typeahead-utils.js

[4.5/n] Native Typeahead - Refactoring to the common utility functionClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 22210

lib/shared/typeahead-utils.js

web/utils/typeahead-utils.js

[4.5/n] Native Typeahead - Refactoring to the common utility function
ClosedPublic
Actions

Revision Contents
Changeset List