Page MenuHomePhabricator
Differential D6342

[web] Move AppSwitcher to web/topbar
ClosedPublic
Actions

Authored by inka on Jan 23 2023, 8:35 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 14, 10:28 AM
Unknown Object (File)
Mon, Oct 28, 6:55 AM
Unknown Object (File)
Oct 12 2024, 8:03 AM
Unknown Object (File)
Sep 28 2024, 12:27 PM
Unknown Object (File)
Sep 28 2024, 12:27 PM
Unknown Object (File)
Sep 28 2024, 12:27 PM
Unknown Object (File)
Sep 28 2024, 12:27 PM
Unknown Object (File)
Sep 28 2024, 12:27 PM
View All 94 Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
• przemek
michal
bartek
Commits
rCOMM4e62723fcb9e: [web] Move AppSwitcher to web/topbar
Summary

issue: https://linear.app/comm/issue/ENG-2739/move-navigationpanel-from-the-sidebar-to-a-top-bar
Moving the AppSwitcher from web/sidebar to web/topbar becaue it will be used only in the top bar in the near future.

Test Plan

Run the web app, check that the AppSwitcher works properly.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

inka created this revision.Jan 23 2023, 8:35 AM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptJan 23 2023, 8:35 AM
inka added a parent revision: D6341: [web] Create a dummy topbar component.Jan 23 2023, 8:36 AM
Harbormaster completed remote builds in B15537: Diff 21197.Jan 23 2023, 8:49 AM
inka requested review of this revision.Jan 23 2023, 8:49 AM
inka added a child revision: D6343: [web] Add possibility for the navigation-panel to be horizontal.Jan 23 2023, 8:59 AM
inka edited the summary of this revision. (Show Details)Jan 24 2023, 12:34 AM
bartek accepted this revision.Jan 24 2023, 2:05 AM
This revision is now accepted and ready to land.Jan 24 2023, 2:05 AM
inka updated this revision to Diff 22445.Feb 13 2023, 7:14 AM

Rebase

Harbormaster failed remote builds in B16408: Diff 22445!Feb 13 2023, 7:28 AM
inka updated this revision to Diff 22533.Feb 14 2023, 2:31 AM

Rebase

Harbormaster completed remote builds in B16486: Diff 22533.Feb 14 2023, 3:09 AM
Closed by commit rCOMM4e62723fcb9e: [web] Move AppSwitcher to web/topbar (authored by • InkaSokolowska). · Explain WhyFeb 14 2023, 5:02 AM
This revision was automatically updated to reflect the committed changes.
• InkaSokolowska added a commit: rCOMM4e62723fcb9e: [web] Move AppSwitcher to web/topbar.

Revision Contents
Changeset List

PathSize
web/
sidebar/
2 lines
topbar/
sidebar/
4 lines

Diff 22445

View Options

web/sidebar/app-switcher.react.js

Loading...
View Options

web/sidebar/left-layout-aside.react.js

Loading...
View Options

web/topbar/app-switcher.react.js

Loading...