Linear issue: https://linear.app/comm/issue/ENG-2775/white-frame-inside-of-search-bar
After some changes to a different part of the code, I was seeing a white frame inside of the search bar, due to a style from styles.css (for textarea) taking precedence over this style. This was happening most likely because of hot-reload.
It was happening when I was saving files or checking out a commit. But once I reloaded the page it was back to normal. It wasn't happening on production. So I'm adding this only so that other devs are not alarmed in the future.
Details
Details
Run web app (dev mode) on a different commit. Checked out to this commit (this used to cause the frame to appear). Checked that the frame is not present.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| web/components/search.css | ||
|---|---|---|
| 15–16 ↗ | (On Diff #21217) | We're putting two selectors here... do we need both? Or only one? |
| web/components/search.css | ||
|---|---|---|
| 15–16 ↗ | (On Diff #21217) | It's technically not needed, but if I remove input.searchInput then this glitch happens when I checkout the branch (so it would likely also happen in other cases when files are being reloaded): So I'd rather just leave it... |
| web/components/search.css | ||
|---|---|---|
| 15–16 ↗ | (On Diff #21217) | It's surprising that deleting input.searchInput, causes an issue, but I don't think we should spend too much time investigating this |
| web/components/search.css | ||
|---|---|---|
| 15–16 ↗ | (On Diff #21217) | Agree we shouldn't spend too much time on it, this is fine |