issue: https://linear.app/comm/issue/ENG-2739/move-navigationpanel-from-the-sidebar-to-a-top-bar
Adding a Topbar component that will contain the AppSwitcher and the navigation info bar. It will be displayed in the Inbox tab.
For now it displays "dummy", because adding it's contents requires a lot of changes to the code. So in the interest of keeping the diff small it has a dummy content for now.
Details
Details
Displayed it in the App component.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| web/topbar/topbar.react.js | ||
|---|---|---|
| 9 ↗ | (On Diff #21196) | Always use $ReadOnly if possible! |
Comment Actions
Remove returning null from Topbar, when in settings tab. I changed the approach, and now it is handled by the parent. This provides a better separation of responsibilities
| web/topbar/topbar.react.js | ||
|---|---|---|
| 11–13 ↗ | (On Diff #21240) | This component will display the AppSwitcher, that will mostly stay the same. It'll change on it's own when user changes selected apps based on selectors. |
| web/topbar/topbar.react.js | ||
|---|---|---|
| 11–13 ↗ | (On Diff #21240) | like LeftLayoutAside used to be. It displayed the AppSwitcher before. It was a very similar component to what this will be |