Page MenuHomePhabricator

[web] gate avatars rendering
ClosedPublic

Authored by ginsu on Apr 3 2023, 2:13 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 8, 3:35 AM
Unknown Object (File)
Fri, Nov 8, 3:35 AM
Unknown Object (File)
Wed, Nov 6, 3:27 AM
Unknown Object (File)
Wed, Nov 6, 3:27 AM
Unknown Object (File)
Tue, Nov 5, 10:23 PM
Unknown Object (File)
Sun, Oct 27, 1:14 AM
Unknown Object (File)
Sun, Oct 27, 1:14 AM
Unknown Object (File)
Sun, Oct 27, 1:14 AM

Details

Summary

Added a hard variable called shouldRenderAvatars to gate the avatars rendering work for web. Gating this work will allow me to land all the diffs in this stack without launching avatars. I know this is a big diff; however, when we eventually have avatars in stable condition, I think it will be nice to get rid of this code, so having one diff that shows all the changes that need to be "reverted" is why I decided to make this diff bigger than normal.

Depends on D7276

Test Plan

Tested all areas that have avatars and made sure that the avatars didn't render when the gate was closed:

When the gate is closed:

Screenshot 2023-04-03 at 5.18.27 AM.png (1×3 px, 1 MB)

When the gate is open:

Screenshot 2023-04-03 at 5.18.19 AM.png (1×3 px, 1 MB)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu requested review of this revision.Apr 3 2023, 2:28 AM

I know this is a big diff; however, when we eventually have avatars in stable condition, I think it will be nice to get rid of this code, so having one diff that shows all the changes that need to be "reverted" is why I decided to make this diff bigger than normal.

Good call

This revision is now accepted and ready to land.Apr 3 2023, 12:56 PM
This revision was automatically updated to reflect the committed changes.
ginsu added inline comments.
web/utils/avatar-utils.js
3 ↗(On Diff #24632)