Details
Details
- Unit tests are added in D7090
- Also note that we successfully ran Olm C++ and JS test suites
- I also patched the web app to confirm it worked
- Confirmed the iOS app builds
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
native/cpp/CommonCpp/CryptoTools/Session.cpp | ||
---|---|---|
32 ↗ | (On Diff #23816) | This is not great... we're doing pointer arithmetic on a vector's data, and using an offset based on the number of chars we need to seek into the JSON blob Note that this code isn't actually used in production yet and wasn't referenced outside of the CryptoTest.mm file (deleted, more context on that in a separate comment) |
native/ios/Comm.xcodeproj/project.pbxproj | ||
991 ↗ | (On Diff #23816) | This might be controversial, but I deleted CryptoTest.mm. My understanding is that it's failing and I didn't really have context on why, but it's been failing for a while. It looks kind of messy and I'm not sure I have the cycles right now to fix it, and I don't want to block monthly goals on it. Open to creating a follow-up task if people want to keep this test around |