[lib] add ops for message store threads
ClosedPublic
Actions

Authored by kamil on Apr 12 2023, 9:43 AM.

Details

Reviewers

tomek
marcin
atul

Commits

rCOMM1bc50d14e8a2: [lib] add ops for message store threads

Summary

Operations to remove, replace, and remove all threads.

Test Plan

Process each operation and check if it works.

Diff Detail

Repository

rCOMM Comm

Branch

ops-for-ms

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Apr 12 2023, 9:43 AM

kamil held this revision as a draft.

Herald added subscribers: atul, ashoat. · View Herald TranscriptApr 12 2023, 9:43 AM

kamil added a child revision: D7397: [lib] restore function for asserting store after performing ops.Apr 12 2023, 9:51 AM

kamil added inline comments.Apr 12 2023, 9:53 AM

lib/utils/message-ops-utils.js
254	to avoid native crashes for now, filtering or any other more readable approach makes flow complaining

Harbormaster completed remote builds in B18273: Diff 25045.Apr 12 2023, 10:02 AM

rebase

Harbormaster completed remote builds in B18317: Diff 25099.Apr 13 2023, 7:38 AM

kamil published this revision for review.Apr 13 2023, 8:18 AM

kamil added inline comments.

lib/types/message-types.js
416 ↗	(On Diff #25099)	Threads are small objects, and there might be a situation when we will update a lot of them at once - that's why it's better to make one operation with multiple threads to reduce overhead.

@atul is rather busy right now and probably won't be able to review anytime soon, but if I recall correctly I think he was the original architect of the message ops, so would be good for him to take a pass here

In D7396#221029, @ashoat wrote:

@atul is rather busy right now and probably won't be able to review anytime soon, but if I recall correctly I think he was the original architect of the message ops, so would be good for him to take a pass here

I can take a look this weekend after avatars work... hopefully that's not too much of a delay.

tomek accepted this revision.Apr 14 2023, 4:54 AM

This revision is now accepted and ready to land.Apr 14 2023, 4:54 AM

kamil mentioned this in D7469: [CommCoreModule] implement ops for message store threads.Apr 17 2023, 10:07 AM

rebase before landing

Harbormaster completed remote builds in B18506: Diff 25343.Apr 19 2023, 9:20 AM

Closed by commit rCOMM1bc50d14e8a2: [lib] add ops for message store threads (authored by kamil). · Explain WhyApr 19 2023, 10:28 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM1bc50d14e8a2: [lib] add ops for message store threads.

kamil mentioned this in rCOMM7c2d19d001ba: [CommCoreModule] implement ops for message store threads.Apr 21 2023, 2:22 AM