Page MenuHomePhabricator
Differential D8289

[web] Style "Emoji" tab of `EmojiAvatarSelectionModal`
ClosedPublic
Actions

Authored by atul on Jun 21 2023, 4:26 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 13, 4:54 AM
Unknown Object (File)
Sat, Nov 9, 4:43 PM
Unknown Object (File)
Sat, Nov 9, 4:43 PM
Unknown Object (File)
Sat, Nov 9, 4:39 PM
Unknown Object (File)
Sat, Nov 9, 4:07 PM
Unknown Object (File)
Sat, Nov 9, 4:07 PM
Unknown Object (File)
Sat, Nov 9, 10:16 AM
Unknown Object (File)
Oct 3 2024, 9:01 PM
View All Files
Subscribers
tomek

Details

Reviewers
ashoat
ginsu
rohan
Commits
rCOMM12e2671bb066: [web] Style "Emoji" tab of `EmojiAvatarSelectionModal`
Summary

Here's how it looks:

87d95f.png (1×1 px, 267 KB)

Here it is w/ some "debugging" guides:

31f722.png (1×1 px, 264 KB)

Depends on D8287

Test Plan

NA, see above

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Jun 21 2023, 4:26 PM
Herald added a subscriber: tomek. · View Herald TranscriptJun 21 2023, 4:26 PM
atul published this revision for review.Jun 21 2023, 4:27 PM
atul edited the summary of this revision. (Show Details)
atul added inline comments.
web/avatars/emoji-avatar-selection-modal.css
5

Don't love hardcoding dimensions, but not sure how else to keep the tabs the same height

atul updated this revision to Diff 27989.Jun 21 2023, 4:30 PM

update min-height to account for tabBody padding

Harbormaster completed remote builds in B20416: Diff 27988.Jun 21 2023, 4:43 PM
Harbormaster completed remote builds in B20417: Diff 27989.Jun 21 2023, 4:47 PM
ginsu accepted this revision.Jun 22 2023, 4:08 PM
This revision is now accepted and ready to land.Jun 22 2023, 4:08 PM
atul updated this revision to Diff 28084.Jun 23 2023, 1:57 PM

rebase before landing

This revision was landed with ongoing or failed builds.Jun 23 2023, 2:07 PM
Closed by commit rCOMM12e2671bb066: [web] Style "Emoji" tab of `EmojiAvatarSelectionModal` (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM12e2671bb066: [web] Style "Emoji" tab of `EmojiAvatarSelectionModal`.
Harbormaster completed remote builds in B20498: Diff 28084.Jun 23 2023, 2:57 PM

Revision Contents
Changeset List

Diff 27988

View Options

web/avatars/emoji-avatar-selection-modal.css

Loading...
View Options

web/avatars/emoji-avatar-selection-modal.react.js

Loading...