Page MenuHomePhabricator
Differential D8291

[web] Inline MessageSearchModalContent
ClosedPublic
Actions

Authored by inka on Jun 22 2023, 7:19 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 8, 6:01 AM
Unknown Object (File)
Fri, Nov 1, 8:17 AM
Unknown Object (File)
Fri, Nov 1, 3:47 AM
Unknown Object (File)
Oct 7 2024, 6:55 PM
Unknown Object (File)
Oct 7 2024, 1:10 AM
Unknown Object (File)
Oct 5 2024, 12:59 AM
Unknown Object (File)
Oct 2 2024, 9:26 AM
Unknown Object (File)
Oct 2 2024, 9:26 AM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
kamil
• kuba
michal
Commits
rCOMM6584accda026: [web] Inline MessageSearchModalContent
Summary

After D8274 MessageSearchModalContent can be inlined. This is also needed for later diffs, where this separation was making the code unnecessarily complex
issue: https://linear.app/comm/issue/ENG-3462/add-modal-for-searching-messages

Test Plan

Checked that message search modal still works

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

inka created this revision.Jun 22 2023, 7:19 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 22 2023, 7:19 AM
inka added a parent revision: D8290: [web] Extract useParseSearchResults.Jun 22 2023, 7:20 AM
inka edited the summary of this revision. (Show Details)
inka edited the summary of this revision. (Show Details)
Harbormaster returned this revision to the author for changes because remote builds failed.Jun 22 2023, 7:33 AM
Harbormaster failed remote builds in B20422: Diff 27996!
inka added a child revision: D8293: [web] Add to MessageSearchContext results related information.Jun 22 2023, 7:42 AM
inka updated this revision to Diff 28004.Jun 22 2023, 7:54 AM

Rebase

Harbormaster returned this revision to the author for changes because remote builds failed.Jun 22 2023, 8:16 AM
Harbormaster failed remote builds in B20430: Diff 28004!
inka requested review of this revision.Jun 23 2023, 1:17 AM
michal accepted this revision.Jun 23 2023, 3:40 AM
michal added inline comments.
web/modals/search/message-search-modal.react.js
176
This revision is now accepted and ready to land.Jun 23 2023, 3:40 AM
inka updated this revision to Diff 28044.Jun 23 2023, 5:34 AM

Address review, rebase

Harbormaster failed remote builds in B20462: Diff 28044!Jun 23 2023, 5:55 AM
inka updated this revision to Diff 28050.Jun 23 2023, 8:26 AM

Changes due to changes in D8272

Harbormaster failed remote builds in B20468: Diff 28050!Jun 23 2023, 8:48 AM
Harbormaster completed remote builds in B20468: Diff 28050.Jun 26 2023, 7:39 AM
inka added a child revision: D8302: [web] Add message search button.Jun 27 2023, 4:21 AM
inka removed a child revision: D8293: [web] Add to MessageSearchContext results related information.Jun 27 2023, 4:25 AM
Closed by commit rCOMM6584accda026: [web] Inline MessageSearchModalContent (authored by • InkaSokolowska). · Explain WhyJun 27 2023, 4:26 AM
This revision was automatically updated to reflect the committed changes.
• InkaSokolowska added a commit: rCOMM6584accda026: [web] Inline MessageSearchModalContent.

Revision Contents
Changeset List

PathSize
web/
modals/
search/
55 lines

Diff 28004

View Options

web/modals/search/message-search-modal.react.js

Loading...