Page MenuHomePhabricator
Differential D8275

[web] Make pressing enter initiate search
ClosedPublic
Actions

Authored by inka on Jun 21 2023, 5:59 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 14, 8:35 PM
Unknown Object (File)
Sat, Nov 9, 4:20 AM
Unknown Object (File)
Fri, Nov 8, 11:04 PM
Unknown Object (File)
Fri, Nov 1, 8:17 AM
Unknown Object (File)
Fri, Nov 1, 5:33 AM
Unknown Object (File)
Oct 15 2024, 4:58 PM
Unknown Object (File)
Oct 11 2024, 5:29 AM
Unknown Object (File)
Oct 2 2024, 9:25 AM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
kamil
• kuba
michal
Commits
rCOMMe83333f8851d: [web] Make pressing enter initiate search
Summary

issue: https://linear.app/comm/issue/ENG-4152/make-pressing-enter-initiate-search

Test Plan

Tested that pressing enter starts search

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

inka created this revision.Jun 21 2023, 5:59 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 21 2023, 5:59 AM
Harbormaster completed remote builds in B20379: Diff 27928.Jun 21 2023, 6:17 AM
inka requested review of this revision.Jun 21 2023, 6:17 AM
inka added a parent revision: D8274: [web] Use message search context in message search modal.Jun 22 2023, 7:13 AM
inka added a child revision: D8290: [web] Extract useParseSearchResults.Jun 22 2023, 7:16 AM
michal accepted this revision.Jun 23 2023, 2:13 AM
michal added inline comments.
web/modals/search/message-search-modal.react.js
241 ↗(On Diff #27928)

Is there a reason this is on the container and not on e.g. Search?

This revision is now accepted and ready to land.Jun 23 2023, 2:13 AM
inka updated this revision to Diff 28034.Jun 23 2023, 2:41 AM

Move onKeyDown to Search

inka updated this revision to Diff 28039.Jun 23 2023, 3:01 AM

Rebase

Harbormaster failed remote builds in B20452: Diff 28034!Jun 23 2023, 3:03 AM
Harbormaster failed remote builds in B20457: Diff 28039!Jun 23 2023, 3:23 AM
inka updated this revision to Diff 28049.Jun 23 2023, 8:25 AM

Rebase

Harbormaster failed remote builds in B20467: Diff 28049!Jun 23 2023, 8:48 AM
Harbormaster completed remote builds in B20467: Diff 28049.Jun 26 2023, 7:38 AM
Closed by commit rCOMMe83333f8851d: [web] Make pressing enter initiate search (authored by • InkaSokolowska). · Explain WhyJun 27 2023, 4:26 AM
This revision was automatically updated to reflect the committed changes.
• InkaSokolowska added a commit: rCOMMe83333f8851d: [web] Make pressing enter initiate search.

Revision Contents
Changeset List

PathSize
web/
modals/
search/
10 lines

Diff 28049

View Options

web/modals/search/message-search-modal.react.js

Loading...