Page MenuHomePhabricator
Differential D8286

[web] Remove `LoadingIndicator` from `EditUserAvatar`
ClosedPublic
Actions

Authored by atul on Jun 21 2023, 3:39 PM.
Tags
None
Referenced Files
F3529958: D8286.diff
Tue, Dec 24, 10:31 PM
Unknown Object (File)
Sat, Dec 14, 2:25 AM
Unknown Object (File)
Nov 23 2024, 1:52 PM
Unknown Object (File)
Nov 23 2024, 1:12 PM
Unknown Object (File)
Nov 23 2024, 1:12 PM
Unknown Object (File)
Nov 23 2024, 1:11 PM
Unknown Object (File)
Nov 23 2024, 1:11 PM
Unknown Object (File)
Nov 9 2024, 5:43 PM
View All Files
Subscribers
tomek

Details

Reviewers
ashoat
ginsu
rohan
Commits
rCOMMce4888d64b5f: [web] Remove `LoadingIndicator` from `EditUserAvatar`
Summary

In D8285 we introduced a showSpinner prop to the Avatar component. In this diff we remove the LoadingIndicator from EditUserAvatar component and instead pass showSpinner down to Avatar to take advantage of that.

This deduplicates redundant spinner code. Now that we have a "toggleable" spinner in Avatar, components derived from it can use that spinner "for free."

Depends on D8285

Test Plan

Things continue to look as expected:

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Jun 21 2023, 3:39 PM
Herald added a subscriber: tomek. · View Herald TranscriptJun 21 2023, 3:39 PM
atul published this revision for review.Jun 21 2023, 3:40 PM
atul edited the test plan for this revision. (Show Details)
atul edited the summary of this revision. (Show Details)
atul edited the summary of this revision. (Show Details)
Harbormaster completed remote builds in B20413: Diff 27985.Jun 21 2023, 4:03 PM
atul added a child revision: D8287: [web] Split `EmojiAvatarSelectionModal` into "Emoji" and "Color" tab.Jun 21 2023, 4:04 PM
rohan accepted this revision.Jun 22 2023, 6:29 AM
This revision is now accepted and ready to land.Jun 22 2023, 6:29 AM
atul updated this revision to Diff 28082.Jun 23 2023, 1:56 PM

rebase before landing

This revision was landed with ongoing or failed builds.Jun 23 2023, 2:07 PM
Closed by commit rCOMMce4888d64b5f: [web] Remove `LoadingIndicator` from `EditUserAvatar` (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMMce4888d64b5f: [web] Remove `LoadingIndicator` from `EditUserAvatar`.
Harbormaster completed remote builds in B20496: Diff 28082.Jun 23 2023, 2:45 PM

Revision Contents
Changeset List

Diff 28082

View Options

web/avatars/edit-user-avatar.css

Loading...
View Options

web/avatars/edit-user-avatar.react.js

Loading...
View Options

web/avatars/user-avatar.react.js

Loading...