[web] Add message search modal
ClosedPublic
Actions

Authored by inka on Jun 16 2023, 6:12 AM.

Details

Reviewers

kamil
• kuba
michal

Commits

rCOMM74f293469070: [web] Add message search modal

Summary

issue: https://linear.app/comm/issue/ENG-3462/add-modal-for-searching-messages
For now the server is called after every key press, this will be changed in the future. Some elements like the "search" button and the footers are not yet implemented. For now the query is not stored
anywhere

Test Plan

opened the modal and checked that it works - typed in query is sent to the server and the results show up. Checked that when the user scrolls to the bottom new messages are fetched.

I checked that all tooltip actions work

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

inka created this revision.Jun 16 2023, 6:12 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 16 2023, 6:13 AM

Harbormaster completed remote builds in B20313: Diff 27837.Jun 16 2023, 6:30 AM

inka requested review of this revision.Jun 16 2023, 6:30 AM

inka edited the summary of this revision. (Show Details)Jun 16 2023, 7:16 AM

inka edited the test plan for this revision. (Show Details)

inka attached a referenced file: F591283: Screen Recording 2023-06-16 at 15.13.49.mov. (Show Details)

inka added a parent revision: D8207: [web] Change how margins / paddings are used in message result.

inka added a child revision: D8241: [web] Add footers to message search modal.

• kuba added inline comments.Jun 16 2023, 7:42 AM

web/modals/search/message-search-modal.css
3 ↗	(On Diff #27837)	We can use a shorter version here.
web/modals/search/message-search-modal.react.js
148 ↗	(On Diff #27837)	Probably you forgot to remove it.