Page MenuHomePhabricator
Differential D8404

[Keyserver/rust] Remove legacy auth_token configuration
ClosedPublic
Actions

Authored by • jon on Jun 30 2023, 3:39 PM.
Tags
None
Referenced Files
F2829936: D8404.id28721.diff
Fri, Sep 27, 5:56 PM
F2829934: D8404.id28715.diff
Fri, Sep 27, 5:56 PM
F2829933: D8404.id28320.diff
Fri, Sep 27, 5:56 PM
F2829885: D8404.id.diff
Fri, Sep 27, 5:55 PM
F2829840: D8404.diff
Fri, Sep 27, 5:49 PM
Unknown Object (File)
Mon, Sep 23, 3:56 AM
Unknown Object (File)
Sun, Sep 22, 4:42 AM
Unknown Object (File)
Sat, Sep 21, 6:33 PM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
varun
Commits
rCOMM0955edc89f9b: [Keyserver/rust] Remove legacy auth_token configuration
Summary

Follow up to deprecating the old keyserver proxy service

Depends on D8402

Test Plan

N/A

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• jon created this revision.Jun 30 2023, 3:39 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 30 2023, 3:39 PM
• jon added a child revision: D8405: [Keyserver] Attempt login to identity service.Jun 30 2023, 4:05 PM
Harbormaster completed remote builds in B20664: Diff 28320.Jun 30 2023, 4:19 PM
• jon requested review of this revision.Jun 30 2023, 4:19 PM
varun accepted this revision.Jul 1 2023, 8:43 AM
This revision is now accepted and ready to land.Jul 1 2023, 8:43 AM
ashoat added a comment.Jul 3 2023, 10:33 AM

After this lands, I can remove identity_auth_token from my production keyserver config, yeah?

• jon mentioned this in D8366: [Keyserver/rust] Add device login and register.Jul 4 2023, 1:08 PM
• jon edited parent revisions, added: D8403: [Keyserver/rust] Enable logging of rust addon; removed: D8402: [Identity] Fix opaque login.Jul 6 2023, 9:17 AM
• jon added a comment.Jul 6 2023, 9:31 AM

After this lands, I can remove identity_auth_token from my production keyserver config, yeah?

After we deploy a new version of identity service, yes.

ashoat added a comment.Jul 6 2023, 12:43 PM
In D8404#248608, @jon wrote:

After this lands, I can remove identity_auth_token from my production keyserver config, yeah?

After we deploy a new version of identity service, yes.

Okay, if you (or @varun, whoever does the deploy) can let me know when that happens, then I can remove it from the keyserver config

• jon updated this revision to Diff 28715.Jul 16 2023, 7:14 PM
• jon added a parent revision: D8402: [Identity] Fix opaque login.

Rebase on master

This revision was landed with ongoing or failed builds.Jul 16 2023, 7:39 PM
Closed by commit rCOMM0955edc89f9b: [Keyserver/rust] Remove legacy auth_token configuration (authored by • jon). · Explain Why
This revision was automatically updated to reflect the committed changes.
• jon added a commit: rCOMM0955edc89f9b: [Keyserver/rust] Remove legacy auth_token configuration.
Harbormaster completed remote builds in B20959: Diff 28715.Jul 17 2023, 1:21 AM

Revision Contents
Changeset List

PathSize
keyserver/
addons/
rust-node-addon/
src/
identity_client/
2 lines

Diff 28320

View Options

keyserver/addons/rust-node-addon/src/identity_client/mod.rs

Loading...