Page MenuHomePhabricator
Differential D8463

[Services-test/identity] Refactor create_device
ClosedPublic
Actions

Authored by • jon on Jul 10 2023, 6:28 AM.
Tags
None
Referenced Files
F3515311: D8463.id28550.diff
Sun, Dec 22, 8:26 AM
Unknown Object (File)
Mon, Dec 16, 10:27 AM
Unknown Object (File)
Mon, Dec 16, 10:27 AM
Unknown Object (File)
Mon, Dec 16, 10:26 AM
Unknown Object (File)
Mon, Dec 16, 10:26 AM
Unknown Object (File)
Sat, Dec 14, 9:01 PM
Unknown Object (File)
Nov 14 2024, 9:09 PM
Unknown Object (File)
Nov 9 2024, 10:04 AM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
bartek
varun
Commits
rCOMM921c2da41054: [Services-test/identity] Refactor create_device
Summary

This function is useful for a lot of scenarios,
make into it's own function, to allow for it to be used
in many locations

In support for testing RefreshUserPreKey:

https://linear.app/comm/issue/ENG-3942

Depends on D8434

Test Plan

Start docker, localstack, run terraform

cd services/commtest
cargo test --test identity_access_tokens_tests

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• jon created this revision.Jul 10 2023, 6:28 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 10 2023, 6:28 AM
• jon added a child revision: D8464: [Identity] Implement RefreshUserPreKey.Jul 10 2023, 6:30 AM
Harbormaster completed remote builds in B20845: Diff 28550.Jul 10 2023, 6:51 AM
• jon requested review of this revision.Jul 10 2023, 6:51 AM
bartek accepted this revision.Jul 11 2023, 10:22 AM
This revision is now accepted and ready to land.Jul 11 2023, 10:22 AM
• jon added inline comments.Jul 13 2023, 10:05 AM
services/commtest/src/identity/device.rs
96–103

kind of annoying that phabricator is showing this as a copy + delete, instead of a partial add.

• jon updated this revision to Diff 28964.Jul 24 2023, 6:32 AM

Rebase on master

Harbormaster completed remote builds in B21142: Diff 28964.Jul 24 2023, 6:51 AM
• jon updated this revision to Diff 29594.Aug 7 2023, 8:33 AM

Rebase on master

Harbormaster completed remote builds in B21570: Diff 29594.Aug 7 2023, 8:51 AM
Closed by commit rCOMM921c2da41054: [Services-test/identity] Refactor create_device (authored by • jon). · Explain WhyAug 8 2023, 7:56 AM
This revision was automatically updated to reflect the committed changes.
• jon added a commit: rCOMM921c2da41054: [Services-test/identity] Refactor create_device.

Revision Contents
Changeset List

PathSize
services/
commtest/
src/
identity/
tests/
device.rs
identity_access_tokens_tests.rs
61 lines
src/
identity/
1 line
1 line
tests/
95 lines

Diff 28550

View Options

services/commtest/src/identity/device.rs

Loading...
View Options

services/commtest/src/identity/mod.rs

Loading...
View Options

services/commtest/src/lib.rs

Loading...
View Options

services/commtest/tests/identity_access_tokens_tests.rs

Loading...