Page MenuHomePhabricator

[nix] Enable C++17 support for Emscripten
ClosedPublic

Authored by kamil on Jul 12 2023, 6:18 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Oct 26, 1:59 AM
Unknown Object (File)
Wed, Oct 23, 8:58 PM
Unknown Object (File)
Wed, Oct 23, 8:26 PM
Unknown Object (File)
Mon, Oct 14, 11:07 PM
Unknown Object (File)
Oct 6 2024, 1:58 PM
Unknown Object (File)
Sep 28 2024, 2:20 AM
Unknown Object (File)
Sep 28 2024, 2:20 AM
Unknown Object (File)
Sep 28 2024, 2:20 AM
Subscribers

Details

Summary

Emscripten is coupled with clang version, according to clang docs C++17 starts from Clang 5.0, while we are using Clang 14.0.6 so should be safe.

Depends on D8487

Test Plan

Run script

Diff Detail

Repository
rCOMM Comm
Branch
wasm-native
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil held this revision as a draft.
web/scripts/run_emscripten.sh
102

this line causing hiding this file by phabricator, so adding a comment to show content

kamil published this revision for review.Jul 12 2023, 7:36 AM

Are we already explicitly using c++17 in native (not c++14 with extensions for 17)? If not it would be good to use it.

This revision is now accepted and ready to land.Jul 14 2023, 2:26 AM

Are we already explicitly using c++17 in native (not c++14 with extensions for 17)?

I think so

This revision was automatically updated to reflect the committed changes.