Page MenuHomePhabricator
Differential D8029

[landing] introduce Discord competitor data
ClosedPublic
Actions

Authored by ginsu on May 30 2023, 8:53 AM.
Tags
None
Referenced Files
F3366971: D8029.id27266.diff
Mon, Nov 25, 1:12 PM
Unknown Object (File)
Tue, Nov 19, 10:54 PM
Unknown Object (File)
Mon, Nov 18, 2:10 PM
Unknown Object (File)
Sun, Nov 17, 2:19 AM
Unknown Object (File)
Sun, Nov 17, 1:37 AM
Unknown Object (File)
Sun, Nov 17, 1:37 AM
Unknown Object (File)
Sun, Nov 17, 1:37 AM
Unknown Object (File)
Sun, Nov 17, 1:37 AM
View All Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
atul
kamil
Commits
rCOMMeba7a2810efe: [landing] introduce Discord competitor data
Summary

introduce discord competitor data. The copy was copied and pasted from this linear task.

Depends on D8028

Test Plan

Please see screenshots below:

Screenshot 2023-08-03 at 12.34.20 PM.png (2×3 px, 969 KB)

Screenshot 2023-08-03 at 12.34.41 PM.png (2×3 px, 931 KB)

Screenshot 2023-08-03 at 12.34.32 PM.png (2×3 px, 910 KB)

Screenshot 2023-08-03 at 12.34.07 PM.png (2×3 px, 833 KB)

Screenshot 2023-08-03 at 12.34.02 PM.png (2×3 px, 883 KB)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.May 30 2023, 8:53 AM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptMay 30 2023, 8:53 AM
ginsu edited the summary of this revision. (Show Details)May 30 2023, 8:56 AM
ginsu edited the summary of this revision. (Show Details)
ginsu added a parent revision: D8028: [landing] key competitor data.
ginsu added a child revision: D8030: [landing] introduce Matrix competitor data.May 30 2023, 8:58 AM
ginsu added a child revision: D8031: [landing] introduce keybase competitor data.May 30 2023, 9:04 AM
ginsu removed a child revision: D8030: [landing] introduce Matrix competitor data.
Harbormaster completed remote builds in B19904: Diff 27266.May 30 2023, 9:11 AM
ginsu requested review of this revision.May 30 2023, 9:11 AM
ginsu updated this revision to Diff 27272.May 30 2023, 11:33 AM

add key

Harbormaster completed remote builds in B19910: Diff 27272.May 30 2023, 11:51 AM
ginsu updated this revision to Diff 28792.Jul 18 2023, 2:04 PM

change long description type from string to $ReadOnlyArray<string>. D8537 introduces logic to the CompetitorFeature so that it can handle multiple paragraphs in the long descriptions.

Harbormaster completed remote builds in B21002: Diff 28792.Jul 18 2023, 2:23 PM
ginsu updated this revision to Diff 29512.Aug 3 2023, 9:36 AM

update copy

ginsu edited the summary of this revision. (Show Details)Aug 3 2023, 9:40 AM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, kamil.
ginsu attached a referenced file: F673968: Screenshot 2023-08-03 at 12.34.20 PM.png. (Show Details)
ginsu attached a referenced file: F673967: Screenshot 2023-08-03 at 12.34.41 PM.png. (Show Details)
ginsu attached a referenced file: F673966: Screenshot 2023-08-03 at 12.34.32 PM.png. (Show Details)
ginsu attached a referenced file: F673965: Screenshot 2023-08-03 at 12.34.07 PM.png. (Show Details)
ginsu attached a referenced file: F673964: Screenshot 2023-08-03 at 12.34.02 PM.png. (Show Details)
ginsu retitled this revision from DRAFT [landing] introduce Discord competitor data to [landing] introduce Discord competitor data.
Harbormaster completed remote builds in B21515: Diff 29512.Aug 3 2023, 12:03 PM
atul accepted this revision.Aug 3 2023, 9:27 PM

Didn't read through copy, but diff looks good.

This revision is now accepted and ready to land.Aug 3 2023, 9:27 PM
ginsu updated this revision to Diff 29661.Aug 8 2023, 12:19 PM

rebase before landing

Harbormaster completed remote builds in B21621: Diff 29661.Aug 8 2023, 1:15 PM
Closed by commit rCOMMeba7a2810efe: [landing] introduce Discord competitor data (authored by ginsu). · Explain WhyAug 8 2023, 2:08 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMeba7a2810efe: [landing] introduce Discord competitor data.

Revision Contents
Changeset List

PathSize
landing/
82 lines

Diff 28792

View Options

landing/competitor-data.js

Loading...